From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58988) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9v3i-0001fH-Pe for qemu-devel@nongnu.org; Tue, 30 Jun 2015 08:54:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z9v3h-00045h-QM for qemu-devel@nongnu.org; Tue, 30 Jun 2015 08:54:42 -0400 Date: Tue, 30 Jun 2015 13:54:29 +0100 From: Stefan Hajnoczi Message-ID: <20150630125429.GA30286@stefanha-thinkpad.redhat.com> References: <1435583533-5758-1-git-send-email-berto@igalia.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="d6Gm4EdcadzBjdND" Content-Disposition: inline In-Reply-To: <1435583533-5758-1-git-send-email-berto@igalia.com> Subject: Re: [Qemu-devel] [PATCH] block: remove redundant check before g_slist_find() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Alexander Yarygin --d6Gm4EdcadzBjdND Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 29, 2015 at 04:12:13PM +0300, Alberto Garcia wrote: > An empty GSList is represented by a NULL pointer, therefore it's a > perfectly valid argument for g_slist_find() and there's no need to > make any additional check. >=20 > Signed-off-by: Alberto Garcia > --- > block/io.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan --d6Gm4EdcadzBjdND Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVkpGFAAoJEJykq7OBq3PI7aMIAI29SreCpvJ8IbUpP0ThKoon F2x2HnvnPatwpN5SoKckmHhCFhtmFw+9HiqPQcsxnRgeNUIpRAa3a1vd2AuGdZEm k9rjabqv/jB2zC38WWO2XHJ6FzKG8dYL36epIZHphFrgKwMPSrrG8hKR8oD2Ru8a WNVmvgxipyQISsk2435TSoxILX/5nrPVpBd9Zz+D5in5sOzPAXfGyQzsm8p5SPNW 67i2Mhaq4pUhQOCd1bSKoHYgN97pV9VCPpuKpynlp+XfYV4MNC6N0Yw2ElJYYWVR KcJfgtFTfW6vSkeQ9yRad4j9aXyxeXMwPk82EMVqRcY2ffN3OYYWORGw4Y2m2XE= =wubz -----END PGP SIGNATURE----- --d6Gm4EdcadzBjdND--