From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32789) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9w28-00054u-Eb for qemu-devel@nongnu.org; Tue, 30 Jun 2015 09:57:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z9w22-0007MH-H7 for qemu-devel@nongnu.org; Tue, 30 Jun 2015 09:57:08 -0400 Date: Tue, 30 Jun 2015 14:56:53 +0100 From: Stefan Hajnoczi Message-ID: <20150630135653.GC31899@stefanha-thinkpad.redhat.com> References: <1435018875-22527-1-git-send-email-jsnow@redhat.com> <1435018875-22527-7-git-send-email-jsnow@redhat.com> <20150626153514.GC31186@stefanha-thinkpad.redhat.com> <558D999B.9090001@redhat.com> <20150629142446.GH32151@stefanha-thinkpad.redhat.com> <55916763.5000209@redhat.com> <55916894.7030501@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="LwW0XdcUbUexiWVK" Content-Disposition: inline In-Reply-To: <55916894.7030501@redhat.com> Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 06/16] ahci: record ncq failures List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: kwolf@redhat.com, Stefan Hajnoczi , qemu-devel@nongnu.org, qemu-block@nongnu.org, pbonzini@redhat.com --LwW0XdcUbUexiWVK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 29, 2015 at 11:47:32AM -0400, John Snow wrote: > > (Perilously tangential side-note: what's the default error action if > > you don't set rerror=3Dstop or werror=3Dstop? the ide code didn't make = it > > particularly clear to me if it was IGNORE or REPORT.) > >=20 >=20 > Still curious about this bit, though. blockdev.c:blockdev_init() is the function that instantiates a -drive: on_write_error =3D BLOCKDEV_ON_ERROR_ENOSPC; if ((buf =3D qemu_opt_get(opts, "werror")) !=3D NULL) { ... on_read_error =3D BLOCKDEV_ON_ERROR_REPORT; if ((buf =3D qemu_opt_get(opts, "rerror")) !=3D NULL) { --LwW0XdcUbUexiWVK Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVkqAlAAoJEJykq7OBq3PIDWoIAI1MWPPwG+4Ft4kUzSKkXEPD Z/8VpHqZlABHRHs6MSaLSilB5NmrF0FmINtmzcrMJ6Ru/yddh0OHL++BhfFTQJLP F3LHsPAc1V7CHPYASae/To85uVTGqMN9pkwG8kFbNEmCakEChxxbl5WmBINQ7RVw 9k3+ao4yForgVMicPK2aylhMeV32ljWjfcR7efVqE/scKkq4O7+uCh0Gkwefql80 kJjXYPhnrgE+ENvaxsZce1b/LNXSb/ORHieW4c/h3vmZ0+2Lyhyb10hX8UpBki2c a/FogHLgFiBHrcmVlz5FmHN5hCTarU7ucEb6EAdaPEsbiD069qsp8GjLhdfwTYk= =1EVr -----END PGP SIGNATURE----- --LwW0XdcUbUexiWVK--