From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49404) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9weK-0006eE-Ey for qemu-devel@nongnu.org; Tue, 30 Jun 2015 10:36:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z9weF-0006LZ-D6 for qemu-devel@nongnu.org; Tue, 30 Jun 2015 10:36:36 -0400 Received: from mail-qk0-f178.google.com ([209.85.220.178]:35010) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9weF-0006LT-92 for qemu-devel@nongnu.org; Tue, 30 Jun 2015 10:36:31 -0400 Received: by qkbp125 with SMTP id p125so7587580qkb.2 for ; Tue, 30 Jun 2015 07:36:30 -0700 (PDT) Date: Tue, 30 Jun 2015 10:36:29 -0400 From: Kevin O'Connor Message-ID: <20150630143628.GA8021@morn.localdomain> References: <1435653553-7728-1-git-send-email-kraxel@redhat.com> <1435653553-7728-3-git-send-email-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1435653553-7728-3-git-send-email-kraxel@redhat.com> Subject: Re: [Qemu-devel] [SeaBIOS] [PATCH v2 02/22] virtio: run drivers in 32bit mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: seabios@seabios.org, qemu-devel@nongnu.org, "Michael S. Tsirkin" On Tue, Jun 30, 2015 at 10:38:53AM +0200, Gerd Hoffmann wrote: > virtio version 1.0 registers can (and actually do in the qemu > implementation) live in mmio space. So we must run the blk and > scsi virtio drivers in 32bit mode, otherwise we can't access them. > > This also allows to drop a bunch of GET_LOWFLAT calls from the virtio > code in the following patches. I think this patch is missing a "if (!MODESEGMENT)" check in src/hw/blockcmd.c - otherwise the virtio scsi code will still be included in the 16bit section. Also, this patch (or a follow up patch) should update the Makefile to not compile the virtio code in 16bit mode. -Kevin