From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37400) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZA9kM-0002Yp-7F for qemu-devel@nongnu.org; Wed, 01 Jul 2015 00:35:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZA9kI-0002wD-Mg for qemu-devel@nongnu.org; Wed, 01 Jul 2015 00:35:42 -0400 Date: Wed, 1 Jul 2015 14:20:37 +1000 From: David Gibson Message-ID: <20150701042037.GN26353@voom.redhat.com> References: <1435556214-2916-1-git-send-email-david@gibson.dropbear.id.au> <1435556214-2916-2-git-send-email-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="xdWF/UuCWMRSqXrg" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH 1/4] Split serial-isa into its own config option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: lvivier@redhat.com, Alexander Graf , Thomas Huth , Markus Armbruster , QEMU Developers , Luiz Capitulino , "qemu-ppc@nongnu.org" , Andreas =?iso-8859-1?Q?F=E4rber?= --xdWF/UuCWMRSqXrg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 29, 2015 at 11:35:23AM +0100, Peter Maydell wrote: > On 29 June 2015 at 06:36, David Gibson wrot= e: > > At present, the core device model code for 8250-like serial ports > > (serial.c) and the code for serial ports attached to ISA-style legacy IO > > (serial-isa.c) are both controlled by the CONFIG_SERIAL variable. > > > > There are lots and lots of embedded platforms that have 8250-like serial > > ports but have never had anything resembling ISA legacy IO. Therefore, > > split serial-isa into its own CONFIG_SERIAL_ISA option so it can be > > disabled for platforms where it's not appropriate. > > > > For now, I enabled CONFIG_SERIAL_ISA in every default-config where > > CONFIG_SERIAL is enabled, excepting microblaze, xtensa and or32. Those > > platforms have technically lost functionality, but since they have no > > other PCI or ISA devices, it's fairly clear they never actually used > > leagacy IO stuff. >=20 > s/leagacy/legacy/ >=20 > Is it worth having a default-configs/isa.mak along the > lines of our current pci.mak and usb.mak, for putting > CONFIG_ defines for all ISA devices? >=20 > A quick grep suggests you can knock arm, moxie, sh4 > and sh4eb off your list of things with CONFIG_SERIAL_ISA > (no hits for ISABus). I'll remove moxie, sh4 and sh4eb in my next spin. I'm not so comfortable about ARM. I get the impression that there are so many x86 people now working in the ARM space, that it wouldn't surprise me at all if some vendors go and stick legacy stuff on there. So I'd prefer to leave it to the ARM people themselves to turn it off if I'm wrong. > I notice in passing that we still have a handful of config > files which set CONFIG_ISA_MMIO, despite that having been > deleted in commit 61fcb628627ea4 two years ago. Hm, I'll add a patch to clean that up, why not. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --xdWF/UuCWMRSqXrg Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVk2qVAAoJEGw4ysog2bOSgSkQAK/Li8fCu9U6SaqQgRoTgdwF LW798M/WzNwrJvoohQSv9hUa/9aj9zHVEJa2mjsrGSvi/0r7aUthk0JgJB4vuVT3 8FV/fia4H2+Tt0gTa0WW1pDlWFuW4e7mCJD/xKMYn+noh+L9bdDTmP+D1960lDSq Nsd+Lkc2YpKHq8P3A3G30ReFWgPb6SJJ1HWBbVOcFR0a4GD+s4IUa1UxCEu2/xbZ z6nmg98zq4+LDC68P+5pEO2lf7HfyDdMUPWgxj8l7wgwoA7aZBrTMlxOblsLD364 LruDst/NV0phsgpjcRBtvo3F1Yf0QnRjp42AUqXjuRGuKLU97vOEUk5M0qtwNTpL xamEtjmf9/PxuqiKYYwbGHzmVHtyw9GBf4t/3KYZUW/YxQiigShPgyxsGFDghRob aeGsAYMf0CnwEc/MedGkbQ2gXwAdEyFxMKXwewlZ7riMiEDilSQoC5hchuRN7iO4 iduCtKmUmoJsRajdlToVyk2C4OUUMBpcewL6X1oYy0zpDtS61HHL3Fw34uby1eMV xb1hKDStcCyJuvO0MfAM3QSwfXABiVvEmYyWTsYqisljX4Mxush0ejB4kjoEcYMH VfO708WpQE3C5S6U1HBARNhMIzSMjsdy4t1UM73Vvjzw6Y1SLtL1v+9sQxQHOpd2 g8R0MyKz0UoHHWIWyk6t =T+XA -----END PGP SIGNATURE----- --xdWF/UuCWMRSqXrg--