From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56234) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAKgq-0006aW-I5 for qemu-devel@nongnu.org; Wed, 01 Jul 2015 12:16:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZAKgm-0007A4-Ba for qemu-devel@nongnu.org; Wed, 01 Jul 2015 12:16:48 -0400 Received: from hall.aurel32.net ([2001:bc8:30d7:100::1]:47969) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAKgm-00079z-5G for qemu-devel@nongnu.org; Wed, 01 Jul 2015 12:16:44 -0400 Date: Wed, 1 Jul 2015 18:16:41 +0200 From: Aurelien Jarno Message-ID: <20150701161641.GA23093@aurel32.net> References: <20150629072310.388.48661.stgit@PASHA-ISP> <20150629072317.388.56900.stgit@PASHA-ISP> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150629072317.388.56900.stgit@PASHA-ISP> Subject: Re: [Qemu-devel] [PATCH v4 1/5] softmmu: add helper function to pass through retaddr List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Dovgalyuk Cc: pbonzini@redhat.com, rth7680@gmail.com, leon.alrae@imgtec.com, qemu-devel@nongnu.org, agraf@suse.de On 2015-06-29 10:23, Pavel Dovgalyuk wrote: > This patch introduces several helpers to pass return address > which points to the TB. Correct return address allows correct > restoring of the guest PC and icount. These functions should be used when > helpers embedded into TB invoke memory operations. > > Signed-off-by: Pavel Dovgalyuk > --- > include/exec/cpu_ldst_template.h | 59 +++++++++++++++++++++++++++++++++----- > softmmu_template.h | 6 ---- > tcg/tcg.h | 23 +++++++++++++++ > 3 files changed, 74 insertions(+), 14 deletions(-) This patch doesn't provide the equivalent _ra functions for the user mode code, so it causes any linux-user target using this to fail to build. I don't think we want to special case this kind of code in the target code, so they need to be provided. Otherwise it looks ok. -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://www.aurel32.net