From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42950) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAWfK-0001L7-UE for qemu-devel@nongnu.org; Thu, 02 Jul 2015 01:04:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZAWfJ-0003o0-5m for qemu-devel@nongnu.org; Thu, 02 Jul 2015 01:04:02 -0400 Date: Thu, 2 Jul 2015 15:01:31 +1000 From: David Gibson Message-ID: <20150702050131.GB25784@voom.redhat.com> References: <1435556214-2916-1-git-send-email-david@gibson.dropbear.id.au> <1435556214-2916-2-git-send-email-david@gibson.dropbear.id.au> <20150701042037.GN26353@voom.redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="yNb1oOkm5a9FJOVX" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH 1/4] Split serial-isa into its own config option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Laurent Vivier , Alexander Graf , Thomas Huth , Markus Armbruster , QEMU Developers , Luiz Capitulino , "qemu-ppc@nongnu.org" , Andreas =?iso-8859-1?Q?F=E4rber?= --yNb1oOkm5a9FJOVX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 01, 2015 at 12:15:09PM +0100, Peter Maydell wrote: > On 1 July 2015 at 05:20, David Gibson wrote: > > On Mon, Jun 29, 2015 at 11:35:23AM +0100, Peter Maydell wrote: > >> A quick grep suggests you can knock arm, moxie, sh4 > >> and sh4eb off your list of things with CONFIG_SERIAL_ISA > >> (no hits for ISABus). > > > > I'll remove moxie, sh4 and sh4eb in my next spin. > > > > I'm not so comfortable about ARM. I get the impression that there are > > so many x86 people now working in the ARM space, that it wouldn't > > surprise me at all if some vendors go and stick legacy stuff on > > there. So I'd prefer to leave it to the ARM people themselves to turn > > it off if I'm wrong. >=20 > I'm an ARM person :-) >=20 > I'm happy to turn ISA off for ARM, except for the case of > generic PCI-to-ISA devices which IIRC you're handling by > having pci.mak set CONFIG_ISA ? >=20 > (In practice that means ARM will still compile in the ISA > code, but hey.) So that makes sense for the patch in this series which allows deconfiguration of the ISA bus itself. But this patch is just about ISA serial ports - given that ARM does have ISA for now, and will still be able to with a bridge it seems odd to disable ISA serial specifically. Come to think of it, the same applies to SH4, since it has PCI. So I've put SERIAL_ISA back in for SH4, and updated the commit message to explain that for now I'm only taking out SERIAL_ISA support for things that clearly have neither ISA nor PCI support. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --yNb1oOkm5a9FJOVX Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVlMWrAAoJEGw4ysog2bOS0qwQAJQM9J8r8KvGnHIlnqmYmT9W 67t3b0XpbHveO0r41NwW/Vt3Y2X7aXacliVeKDsUYyOcrPpPSMiPal4aogVHvqt+ N4K/BLd+RJqOHRfUve+zpM2aYR47bg3Xu+mSP6ZQPUF+CHXdCaX6NTIGrfWRdrBQ SBfsagWDotXx0SVqhWb1B8Swpc4FLD/CnYMCqXOtqC+cYcV4txyZv2mr7ZenxdsX yRqwx/Ajvs1OxZKpXh29p1MxhNAT39HSmwF8umDr+7bl/IKb/b4S0k7mzNZTc2E7 XsFJyBMdpfOZi1eHboB4e0qx9Zi0n7tXn3Fw4yeU74ylDDWpo9cRzxj8cwymj4F8 3q1FR4HupEOCDwPKJ3zPMRZzztmSyMuf16muHR0mJwRMrxyFH+48qk8+WkXhvlQv VQyZYyFGP2C5m6M5095CIPaBWFS0j9LHQa3imVp6R2bEaSy2DeASOqjiiN3d8vOs vb4arJt9XZF2JCd1RLKdPjr1Z7d5OjvgDnZNwF65KImpjW4d5T3ZkyytxEE+F+p6 VUGpDsFJ1L0hbTLvrQxYNIePFIs3cG1PtMUzojR41Mq0wrThI23h7sRCVWNbE+rg /E8U+UKlUhiXQS+V0NJwEBitpJemM11U5XnY6rT7xAMC8cAk2OPjBkRbxgPlr8xL p22TTiteYd7X9EPhY6GH =v8r6 -----END PGP SIGNATURE----- --yNb1oOkm5a9FJOVX--