From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57085) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAXNw-0000t4-Cc for qemu-devel@nongnu.org; Thu, 02 Jul 2015 01:50:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZAXNr-0000XY-8B for qemu-devel@nongnu.org; Thu, 02 Jul 2015 01:50:08 -0400 Received: from mail-lb0-x22f.google.com ([2a00:1450:4010:c04::22f]:33680) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAXNq-0000Uk-Ri for qemu-devel@nongnu.org; Thu, 02 Jul 2015 01:50:03 -0400 Received: by lbcui10 with SMTP id ui10so25314456lbc.0 for ; Wed, 01 Jul 2015 22:50:02 -0700 (PDT) Date: Thu, 2 Jul 2015 08:56:40 +0300 From: Antony Pavlov Message-Id: <20150702085640.9fdcf1295876818e4ee75ee9@gmail.com> In-Reply-To: <16270e45922ea6a8c8622e76f702c46ce7ce15ac.1435723168.git.serge.vakulenko@gmail.com> References: <16270e45922ea6a8c8622e76f702c46ce7ce15ac.1435723168.git.serge.vakulenko@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH pic32 v2 5/5] Two new machine platforms: pic32mz7 and pic32mz. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Serge Vakulenko Cc: Leon Alrae , qemu-devel@nongnu.org, Aurelien Jarno On Tue, 30 Jun 2015 21:12:34 -0700 Serge Vakulenko wrote: > Signed-off-by: Serge Vakulenko > --- > hw/mips/Makefile.objs | 3 + > hw/mips/mips_pic32mx7.c | 1652 +++++++++++++++++++++++++ > hw/mips/mips_pic32mz.c | 2840 +++++++++++++++++++++++++++++++++++++= ++++++ > hw/mips/pic32_ethernet.c | 557 +++++++++ > hw/mips/pic32_gpio.c | 39 + > hw/mips/pic32_load_hex.c | 238 ++++ > hw/mips/pic32_peripherals.h | 210 ++++ > hw/mips/pic32_sdcard.c | 428 +++++++ > hw/mips/pic32_spi.c | 121 ++ > hw/mips/pic32_uart.c | 228 ++++ > hw/mips/pic32mx.h | 1290 ++++++++++++++++++++ > hw/mips/pic32mz.h | 2093 +++++++++++++++++++++++++++++++ > 12 files changed, 9699 insertions(+) > create mode 100644 hw/mips/mips_pic32mx7.c > create mode 100644 hw/mips/mips_pic32mz.c > create mode 100644 hw/mips/pic32_ethernet.c > create mode 100644 hw/mips/pic32_gpio.c > create mode 100644 hw/mips/pic32_load_hex.c > create mode 100644 hw/mips/pic32_peripherals.h > create mode 100644 hw/mips/pic32_sdcard.c > create mode 100644 hw/mips/pic32_spi.c > create mode 100644 hw/mips/pic32_uart.c > create mode 100644 hw/mips/pic32mx.h > create mode 100644 hw/mips/pic32mz.h >=20 > diff --git a/hw/mips/Makefile.objs b/hw/mips/Makefile.objs > index 9633f3a..dcbaec9 100644 > --- a/hw/mips/Makefile.objs > +++ b/hw/mips/Makefile.objs > @@ -3,3 +3,6 @@ obj-y +=3D addr.o cputimer.o mips_int.o > obj-$(CONFIG_JAZZ) +=3D mips_jazz.o > obj-$(CONFIG_FULONG) +=3D mips_fulong2e.o > obj-y +=3D gt64xxx_pci.o > +obj-y +=3D mips_pic32mz.o mips_pic32mx7.o > +obj-y +=3D pic32_load_hex.o pic32_sdcard.o pic32_spi.o pic32_uart.o pic3= 2_gpio.o > +obj-y +=3D pic32_ethernet.o Can we move mips-unrelated stuff to the appropriate dirs? E.g. pic32_gpio.c can to go to hw/gpio. Also please use separate patch for every peripheral controller (see Aurelie= n's comment). > diff --git a/hw/mips/mips_pic32mx7.c b/hw/mips/mips_pic32mx7.c > new file mode 100644 > index 0000000..1d8ffb5 > --- /dev/null > +++ b/hw/mips/mips_pic32mx7.c > @@ -0,0 +1,1652 @@ > +/* > + * QEMU support for Microchip PIC32MX7 microcontroller. > + * > + * Copyright (c) 2015 Serge Vakulenko > + * > + * Permission is hereby granted, free of charge, to any person obtaining= a copy > + * of this software and associated documentation files (the "Software"),= to deal > + * in the Software without restriction, including without limitation the= rights > + * to use, copy, modify, merge, publish, distribute, sublicense, and/or = sell > + * copies of the Software, and to permit persons to whom the Software is > + * furnished to do so, subject to the following conditions: > + * > + * The above copyright notice and this permission notice shall be includ= ed in > + * all copies or substantial portions of the Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRE= SS OR > + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILI= TY, > + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHA= LL > + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR = OTHER > + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISI= NG FROM, > + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALING= S IN > + * THE SOFTWARE. > + */ > + > +/* Only 32-bit little endian mode supported. */ > +#include "config.h" > +#if !defined TARGET_MIPS64 && !defined TARGET_WORDS_BIGENDIAN Please don't use C preprocessor directive for conditional compilation of th= e whole file. Use Makefile instead. See CONFIG_FULONG for example (fulong2e is mips64le-o= nly). --=A0 Best regards, =A0 Antony Pavlov