From: Stefan Hajnoczi <stefanha@gmail.com>
To: Xiao Guangrong <guangrong.xiao@linux.intel.com>
Cc: ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com,
gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org,
stefanha@redhat.com, imammedo@redhat.com, pbonzini@redhat.com,
rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH 14/16] nvdimm: support NFIT_CMD_GET_CONFIG_SIZE function
Date: Thu, 2 Jul 2015 10:23:45 +0100 [thread overview]
Message-ID: <20150702092345.GC20198@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1435762232-15543-15-git-send-email-guangrong.xiao@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 683 bytes --]
On Wed, Jul 01, 2015 at 10:50:30PM +0800, Xiao Guangrong wrote:
> +static uint32_t dsm_cmd_config_size(struct dsm_buffer *in, struct dsm_out *out)
> +{
> + GSList *list = get_nvdimm_built_list();
> + PCNVDIMMDevice *nvdimm = get_nvdimm_device_by_handle(list, in->handle);
> + uint32_t status = NFIT_STATUS_NON_EXISTING_MEM_DEV;
> +
> + if (!nvdimm) {
> + goto exit;
> + }
> +
> + status = NFIT_STATUS_SUCCESS;
> + out->cmd_config_size.config_size = nvdimm->config_data_size;
> + out->cmd_config_size.max_xfer = max_xfer_config_size();
cpu_to_*() missing?
It should be possible to emulate NVDIMMs for a x86_64 guest on a
big-endian host, for example.
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-07-02 9:23 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-01 14:50 [Qemu-devel] [PATCH 00/16] implement vNVDIMM Xiao Guangrong
2015-07-01 14:50 ` [Qemu-devel] [PATCH 01/16] acpi: allow aml_operation_region() working on 64 bit offset Xiao Guangrong
2015-07-01 14:50 ` [Qemu-devel] [PATCH 02/16] i386/acpi-build: allow SSDT to operate on 64 bit Xiao Guangrong
2015-07-01 14:50 ` [Qemu-devel] [PATCH 03/16] acpi: add aml_derefof Xiao Guangrong
2015-07-01 14:50 ` [Qemu-devel] [PATCH 04/16] acpi: add aml_sizeof Xiao Guangrong
2015-07-01 14:50 ` [Qemu-devel] [PATCH 05/16] acpi: add aml_create_field Xiao Guangrong
2015-07-01 14:50 ` [Qemu-devel] [PATCH 06/16] pc: implement NVDIMM device abstract Xiao Guangrong
2015-07-01 14:50 ` [Qemu-devel] [PATCH 07/16] nvdimm: reserve address range for NVDIMM Xiao Guangrong
2015-07-01 14:50 ` [Qemu-devel] [PATCH 08/16] nvdimm: init backend memory mapping and config data area Xiao Guangrong
2015-07-01 14:50 ` [Qemu-devel] [PATCH 09/16] nvdimm: build ACPI NFIT table Xiao Guangrong
2015-07-01 14:50 ` [Qemu-devel] [PATCH 10/16] nvdimm: init the address region used by _DSM method Xiao Guangrong
2015-07-01 14:50 ` [Qemu-devel] [PATCH 11/16] nvdimm: build ACPI nvdimm devices Xiao Guangrong
2015-07-01 14:50 ` [Qemu-devel] [PATCH 12/16] nvdimm: save arg3 for NVDIMM device _DSM method Xiao Guangrong
2015-07-01 14:50 ` [Qemu-devel] [PATCH 13/16] nvdimm: support NFIT_CMD_IMPLEMENTED function Xiao Guangrong
2015-07-01 14:50 ` [Qemu-devel] [PATCH 14/16] nvdimm: support NFIT_CMD_GET_CONFIG_SIZE function Xiao Guangrong
2015-07-02 9:23 ` Stefan Hajnoczi [this message]
2015-07-02 18:02 ` Xiao Guangrong
2015-07-01 14:50 ` [Qemu-devel] [PATCH 15/16] nvdimm: support NFIT_CMD_GET_CONFIG_DATA Xiao Guangrong
2015-07-01 14:50 ` [Qemu-devel] [PATCH 16/16] nvdimm: support NFIT_CMD_SET_CONFIG_DATA Xiao Guangrong
2015-07-02 6:17 ` [Qemu-devel] [PATCH 00/16] implement vNVDIMM Michael S. Tsirkin
2015-07-02 6:34 ` Xiao Guangrong
2015-07-02 8:31 ` Stefan Hajnoczi
2015-07-02 8:35 ` Michael S. Tsirkin
2015-07-02 9:20 ` Stefan Hajnoczi
2015-07-02 9:52 ` Paolo Bonzini
2015-07-02 18:01 ` Xiao Guangrong
2015-07-02 18:11 ` Paolo Bonzini
2015-07-29 8:41 ` Xiao Guangrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150702092345.GC20198@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=ehabkost@redhat.com \
--cc=gleb@kernel.org \
--cc=guangrong.xiao@linux.intel.com \
--cc=imammedo@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).