From: Stefan Hajnoczi <stefanha@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>,
qemu-devel@nongnu.org, chao.zhou@intel.com
Subject: Re: [Qemu-devel] [PATCH] net: Flush queued packets when guest resumes
Date: Thu, 2 Jul 2015 14:13:28 +0100 [thread overview]
Message-ID: <20150702131328.GH21214@stefanha-thinkpad.home> (raw)
In-Reply-To: <1435739014-23610-1-git-send-email-famz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 819 bytes --]
On Wed, Jul 01, 2015 at 04:23:34PM +0800, Fam Zheng wrote:
> Since commit 6e99c63 "net/socket: Drop net_socket_can_send" and friends,
> net queues need to be explicitly flushed after qemu_can_send_packet()
> returns false, because the netdev side will disable the polling of fd.
>
> This fixes the case of "cont" after "stop" (or migration), i.e.
> vm_running changes to true, by listening to vm state changes.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> include/net/net.h | 2 ++
> net/net.c | 14 +++++++++++++-
> 2 files changed, 15 insertions(+), 1 deletion(-)
Please unify this code with:
commit ca77d85e1dbf929ae677a0bac96e9b3edd1704da
Author: Michael S. Tsirkin <mst@redhat.com>
Date: Thu Sep 4 11:39:13 2014 +0300
net: complete all queued packets on VM stop
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-07-02 13:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-01 8:23 [Qemu-devel] [PATCH] net: Flush queued packets when guest resumes Fam Zheng
2015-07-01 8:53 ` Fam Zheng
2015-07-02 13:13 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150702131328.GH21214@stefanha-thinkpad.home \
--to=stefanha@redhat.com \
--cc=chao.zhou@intel.com \
--cc=famz@redhat.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).