From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34531) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAfB5-0005v6-QA for qemu-devel@nongnu.org; Thu, 02 Jul 2015 10:09:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZAfAz-0000fc-Sy for qemu-devel@nongnu.org; Thu, 02 Jul 2015 10:09:23 -0400 Date: Thu, 2 Jul 2015 15:09:07 +0100 From: Stefan Hajnoczi Message-ID: <20150702140907.GO21214@stefanha-thinkpad.home> References: <1435767578-32743-1-git-send-email-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vEfizQhTV1P/vojJ" Content-Disposition: inline In-Reply-To: <1435767578-32743-1-git-send-email-jsnow@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 00/15] ahci: ncq cleanup, part 2 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org --vEfizQhTV1P/vojJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 01, 2015 at 12:19:23PM -0400, John Snow wrote: > requires: 1434470575-21625-1-git-send-email-jsnow@redhat.com > 1435016308-6150-1-git-send-email-jsnow@redhat.com > [PATCH v2 0/4] ahci: misc fixes/tests for 2.4 > [PATCH v2 00/16] ahci: ncq cleanup, part 1 >=20 > This chunk gets NCQ migration and and resume support working. >=20 > There's still some left to do, particularly around error handling > and FIS semantics, but this should get us most of the way there. >=20 > =3D=3D=3D > v2: > =3D=3D=3D >=20 > Key: > [----] : patches are identical > [####] : number of functional differences between upstream/downstream pat= ch > [down] : patch is downstream-only > The flags [FC] indicate (F)unctional and (C)ontextual differences, respec= tively >=20 > 001/15:[0043] [FC] 'ide: add limit to .prepare_buf()' > 002/15:[----] [--] 'ahci: stash ncq command' > 003/15:[----] [--] 'ahci: assert is_ncq for process_ncq' > 004/15:[----] [--] 'ahci: refactor process_ncq_command' > 005/15:[----] [--] 'ahci: factor ncq_finish out of ncq_cb' > 006/15:[down] 'ahci: add rwerror=3Dstop support for ncq' > 007/15:[----] [--] 'ahci: correct types in NCQTransferState' > 008/15:[----] [--] 'ahci: correct ncq sector count' > 009/15:[----] [--] 'qtest/ahci: halted NCQ test' > 010/15:[----] [-C] 'ahci: add cmd header to ncq transfer state' > 011/15:[0004] [FC] 'ahci: add get_cmd_header helper' > 012/15:[0006] [FC] 'ahci: ncq migration' > 013/15:[----] [--] 'ahci: Do not map cmd_fis to generate response' > 014/15:[----] [--] 'qtest/ahci: halted ncq migration test' > 015/15:[0001] [FC] 'ahci: fix sdb fis semantics' >=20 > 01: Fixed limit parameter to int32_t to match existing implicit cap > Removed is_write parameter. Nobody used it. > Implemented PRD limit for BMDMA > 06: Squashed what was patch 06/07. > Adjusted where we clear ncq_tfs->halt. > 11: Fixed port/slot bounds checking > Removed ncq_tfs section from ahci_state_post_load > moved ahead of what's now #12. > 12: Picked up the truncated sections from what's now #11 > Rely on get_cmd_header to do more error checking for us. > 16: Comment explaining the IRQ mechanics for SDBFIS. >=20 > _________________________________________________________________________= _______ >=20 > For convenience, this branch is available at: > https://github.com/jnsnow/qemu.git branch ahci-ncq-s2 > https://github.com/jnsnow/qemu/tree/ahci-ncq-s2 >=20 > This version is tagged ahci-ncq-s2-v2: > https://github.com/jnsnow/qemu/releases/tag/ahci-ncq-s2-v2 >=20 > John Snow (15): > ide: add limit to .prepare_buf() > ahci: stash ncq command > ahci: assert is_ncq for process_ncq > ahci: refactor process_ncq_command > ahci: factor ncq_finish out of ncq_cb > ahci: add rwerror=3Dstop support for ncq > ahci: correct types in NCQTransferState > ahci: correct ncq sector count > qtest/ahci: halted NCQ test > ahci: add cmd header to ncq transfer state > ahci: add get_cmd_header helper > ahci: ncq migration > ahci: Do not map cmd_fis to generate response > qtest/ahci: halted ncq migration test > ahci: fix sdb fis semantics >=20 > hw/ide/ahci.c | 334 +++++++++++++++++++++++++++++++++---------------= ------ > hw/ide/ahci.h | 9 +- > hw/ide/core.c | 15 ++- > hw/ide/internal.h | 4 +- > hw/ide/macio.c | 2 +- > hw/ide/pci.c | 21 +++- > tests/ahci-test.c | 38 +++++-- > 7 files changed, 269 insertions(+), 154 deletions(-) >=20 > --=20 > 2.1.0 >=20 Reviewed-by: Stefan Hajnoczi --vEfizQhTV1P/vojJ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVlUYDAAoJEJykq7OBq3PIxwoH/3gFnKrUHV5OqZfZjLoXkJ8Y N/DE5b3DyK6KdSb6lF/NabAUuXuCxoALdohE/3Ew4Z+FptR97d6zXLxBByLzP20V cE4Pi3sbtZ4Hh/4GUoorsduQCfQt0Fxrt+Fsr9RAnfFPBXg1sgtXE8LHIsmk4WwG 1Cn8160ZUrO7E/bJ8jJgoOzMMK/Z56GRfo8Ez4AWiBL/UhbcMYJOE/uX1dfngK69 tDXQZBg2vOUa0pzQtnG+/M4fOWYzQYYwTetheDVlZy7C3zwuFMUhAHRmpvErimh9 /rORvmAoUZ5437zUeeSo1EvvnCEjrWHSQqRwXrRECStnFpHPzvEkw26PcaGOT5I= =JTgI -----END PGP SIGNATURE----- --vEfizQhTV1P/vojJ--