From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41924) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAfQa-0005Tq-Tf for qemu-devel@nongnu.org; Thu, 02 Jul 2015 10:25:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZAfQX-0001XY-96 for qemu-devel@nongnu.org; Thu, 02 Jul 2015 10:25:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39279) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAfQX-0001XS-3m for qemu-devel@nongnu.org; Thu, 02 Jul 2015 10:25:21 -0400 Date: Thu, 2 Jul 2015 15:25:16 +0100 From: "Daniel P. Berrange" Message-ID: <20150702142516.GG1814@redhat.com> References: <7301d5cb99fe7d96090333fc697c8b1b2d6514a6.1435844519.git.p.fedin@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <7301d5cb99fe7d96090333fc697c8b1b2d6514a6.1435844519.git.p.fedin@samsung.com> Subject: Re: [Qemu-devel] [PATCH v4 4/9] Add virt-v3 machine that uses GIC-500 Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Fedin Cc: Peter Maydell , Eric Auger , Shlomo Pongratz , Shlomo Pongratz , qemu-devel@nongnu.org, Christoffer Dall On Thu, Jul 02, 2015 at 05:14:02PM +0300, Pavel Fedin wrote: > Instead of adding gic-version option, it is much easier to create a new machine > type. The problem is mc->max_cpus. I tried to change this value inside property > handling code, but it simply did not work, and i still got " Maximum CPUs > greater than specified machine type limit" error from qemu. It looks like CPU > number limitation is evaluated before machine is instantiated and properties > are evaluated. It is possible to make a workaround, of course, but it seems to > require much more changes than simply subclassing a machine. > > This patch also introduces kernel_irqchip_type member in Machine class. > Currently it it used only by virt machine for its internal purposes, however in > future it is to be passed to KVM in kvm_irqchip_create(). The variable is > defined as int in order to be architecture agnostic, for potential future > users. > > Signed-off-by: Pavel Fedin As mentioned in previous postings, this should be done as a property on the existing machine type, not a new machine type. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|