From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55894) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAfn2-0007Pg-Mo for qemu-devel@nongnu.org; Thu, 02 Jul 2015 10:48:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZAfmz-0006vx-Qh for qemu-devel@nongnu.org; Thu, 02 Jul 2015 10:48:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47214) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAfmz-0006vW-MO for qemu-devel@nongnu.org; Thu, 02 Jul 2015 10:48:33 -0400 Date: Thu, 2 Jul 2015 15:48:29 +0100 From: Stefan Hajnoczi Message-ID: <20150702144829.GC950@stefanha-thinkpad.redhat.com> References: <558BA5CE.80507@cn.fujitsu.com> <20150701083918.GB13991@stefanha-thinkpad.redhat.com> <5593A9A4.7010305@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="da4uJneut+ArUgXk" Content-Disposition: inline In-Reply-To: <5593A9A4.7010305@cn.fujitsu.com> Subject: Re: [Qemu-devel] [PATCH] more check for replaced node List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wen Congyang Cc: Jeff Cody , Fam Zheng , qemu-devl --da4uJneut+ArUgXk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 01, 2015 at 04:49:40PM +0800, Wen Congyang wrote: > On 07/01/2015 04:39 PM, Stefan Hajnoczi wrote: > > On Thu, Jun 25, 2015 at 02:55:10PM +0800, Wen Congyang wrote: > >> Signed-off-by: Wen Congyang > >> --- > >> block.c | 5 +++-- > >> block/mirror.c | 3 ++- > >> blockdev.c | 2 +- > >> include/block/block.h | 3 ++- > >> 4 files changed, 8 insertions(+), 5 deletions(-) > >=20 > > This patch is missing a commit description. What is the justification > > for this change? >=20 > Sorry, I forgot to add commit messages.. >=20 > Without this patch, the replace node can be any node, and it can be > top BDS with BB, or another quorum's child. With this patch, the replace = node > must be this quorum's child. I think the point of the replace operation was to swap a quorum child with a new drive. It sounds like this patch will break that use case? The idea was that a failed child needs to be replaced. The user adds a new -drive and then uses the mirror+replace to include it into the quorum. I think the new child is not be part of the quorum BDS graph until replacement occurs. Stefan --da4uJneut+ArUgXk Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVlU89AAoJEJykq7OBq3PIbXAIAJtvVPhfIzZvhZiUmoLNxAwu aSAc0a6Jp8IjSrYp3uqkvKEyYHOX67JlZvoRuCGQ/+iJeFlCYitHOWOEupXlhvLc ICto+eadrtl/hhRsFu6XJFlOof8Ax/Wz3IYKr+bQsffePj+dN0fSH/GDx/MkCsdH v5Jxtou4n/O8I5GDbfRBZ31pkcOR5CZOSw+0oStSixJpOL6LqENaD1sO4ERbcn+y bjcCRkfARDHhDj9/QZ0mdy3Oeg5jqrR/XCl06penY8f8mfLUj0XMMdnTQRJDEMQ+ C9Ti+z7Mpng8NziM/AsP5u1Qe6Ia5iWx0Qk0pMwREvOIkStRQDLqYG5b/Z4cRyE= =EuxS -----END PGP SIGNATURE----- --da4uJneut+ArUgXk--