From: "Daniel P. Berrange" <berrange@redhat.com>
To: Pavel Fedin <p.fedin@samsung.com>
Cc: 'Peter Maydell' <peter.maydell@linaro.org>,
'Eric Auger' <eric.auger@linaro.org>,
'Shlomo Pongratz' <shlomo.pongratz@huawei.com>,
'Shlomo Pongratz' <shlomopongratz@gmail.com>,
qemu-devel@nongnu.org,
'Christoffer Dall' <christoffer.dall@linaro.org>
Subject: Re: [Qemu-devel] [PATCH v4 4/9] Add virt-v3 machine that uses GIC-500
Date: Thu, 2 Jul 2015 17:21:37 +0100 [thread overview]
Message-ID: <20150702162137.GK1814@redhat.com> (raw)
In-Reply-To: <02da01d0b4d5$f68a31f0$e39e95d0$@samsung.com>
On Thu, Jul 02, 2015 at 05:47:04PM +0300, Pavel Fedin wrote:
> Hello!
>
> I already explained this earlier: http://lists.nongnu.org/archive/html/qemu-devel/2015-05/msg04842.html, and i tried to explain this in commit message. Current qemu architecture does not allow doing this in a clean way.
> I can simply change mc->max_cpus for 'virt' machine to 64 (always), and
> then check user-supplied value against GIC limitation by myself. And
> produce error. This will be code duplication. Do you think it is better?
> Anybody else (Peter, Cristoffer ?), please vote.
Yes, just increase the declared max cpus to the larger of the two values,
and do a manual check at time of use
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
next prev parent reply other threads:[~2015-07-02 16:21 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-02 14:13 [Qemu-devel] [PATCH v4 0/9] GIC-500 implementation, software + KVM Pavel Fedin
2015-07-02 14:13 ` [Qemu-devel] [PATCH v4 1/9] Implement GIC-500 base class Pavel Fedin
2015-07-02 14:14 ` [Qemu-devel] [PATCH v4 2/9] Implement GIC-500 Pavel Fedin
2015-07-02 14:19 ` Peter Maydell
2015-07-02 14:39 ` Pavel Fedin
2015-07-02 14:42 ` Peter Maydell
2015-07-02 14:45 ` Peter Maydell
2015-07-02 14:14 ` [Qemu-devel] [PATCH v4 3/9] GICv3 support Pavel Fedin
2015-07-02 14:14 ` [Qemu-devel] [PATCH v4 4/9] Add virt-v3 machine that uses GIC-500 Pavel Fedin
2015-07-02 14:25 ` Daniel P. Berrange
2015-07-02 14:47 ` Pavel Fedin
2015-07-02 15:06 ` Christoffer Dall
2015-07-02 15:30 ` Pavel Fedin
2015-07-02 15:54 ` Christoffer Dall
2015-07-03 6:52 ` Pavel Fedin
2015-07-03 7:42 ` Christoffer Dall
2015-07-03 8:47 ` Pavel Fedin
2015-07-03 10:23 ` Christoffer Dall
2015-07-02 16:21 ` Daniel P. Berrange [this message]
2015-07-02 14:14 ` [Qemu-devel] [PATCH v4 5/9] Extract some reusable vGIC code Pavel Fedin
2015-07-02 14:14 ` [Qemu-devel] [PATCH v4 6/9] Set kernel_irqchip_type for the rest of ARM boards which use GIC Pavel Fedin
2015-07-02 14:14 ` [Qemu-devel] [PATCH v4 7/9] Make use of kernel_irqchip_type in kvm_arch_irqchip_create() Pavel Fedin
2015-07-02 14:14 ` [Qemu-devel] [PATCH v4 8/9] Initial implementation of vGICv3 Pavel Fedin
2015-07-02 14:14 ` [Qemu-devel] [PATCH v4 9/9] Enable KVM acceleration for GICv3 Pavel Fedin
2015-07-07 10:20 ` [Qemu-devel] [PATCH v4 0/9] GIC-500 implementation, software + KVM Eric Auger
2015-07-07 12:45 ` Pavel Fedin
2015-07-07 13:27 ` Eric Auger
2015-07-07 14:15 ` Pavel Fedin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150702162137.GK1814@redhat.com \
--to=berrange@redhat.com \
--cc=christoffer.dall@linaro.org \
--cc=eric.auger@linaro.org \
--cc=p.fedin@samsung.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=shlomo.pongratz@huawei.com \
--cc=shlomopongratz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).