From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36021) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAvNS-00014s-VH for qemu-devel@nongnu.org; Fri, 03 Jul 2015 03:27:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZAvNR-0000pp-OM for qemu-devel@nongnu.org; Fri, 03 Jul 2015 03:27:14 -0400 Date: Fri, 3 Jul 2015 17:18:41 +1000 From: David Gibson Message-ID: <20150703071841.GC16378@voom.redhat.com> References: <1435869974-22848-1-git-send-email-mdroth@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="yVhtmJPUSI46BTXb" Content-Disposition: inline In-Reply-To: <1435869974-22848-1-git-send-email-mdroth@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH] target-ppc: fix hugepage support when using memory-backend-file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: qemu-stable@nongnu.org, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, agraf@suse.de --yVhtmJPUSI46BTXb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 02, 2015 at 03:46:14PM -0500, Michael Roth wrote: > Current PPC code relies on -mem-path being used in order for > hugepage support to be detected. With the introduction of > MemoryBackendFile we can now handle this via: > -object memory-file-backend,mem-path=3D...,id=3Dhugemem0 \ > -numa node,id=3Dmem0,memdev=3Dhugemem0 >=20 > Management tools like libvirt treat the 2 approaches as > interchangeable in some cases, which can lead to user-visible > regressions even for previously supported guest configurations. >=20 > Fix these by also iterating through any configured memory > backends that may be backed by hugepages. >=20 > Since the old code assumed hugepages always backed the entirety > of guest memory, play it safe an pick the minimum across the > max pages sizes for all backends, even ones that aren't backed > by hugepages. >=20 > Cc: qemu-stable@nongnu.org > Signed-off-by: Michael Roth Reviewed-by: David Gibson --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --yVhtmJPUSI46BTXb Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVljdRAAoJEGw4ysog2bOS9DwP/1YIezk+7hfQWQ/j9wwy3OTp bDLA2bdMrulOoUBNCk8oHDGt2d/YZK/2ZjZAyHzn12fNQaS5HiYZYnFtg61VDlCg bo1ZuHFP9OEIMgtMU2EcDqqh9Mk4Jvri/H5GCER+N8ME0t5KKoLwDaoqtmlXSlpm cSBCxIsaZ2eRJabI9DtAzNgvHzkIIwDOlCianv3u2KIIhd8nnWTmudWILAUWxTXz h+L4AxoasEzDAchA+5tzOsSR8FppuGffEEWSZYO8GFSn5dRof9XYK9WrCv+d3wQc ircpupMekEaZABzLbk1Q0xpGpI7yjYBGFrAnwNMH9cLdUnr1lSjZOT4XD58VH1n0 NaxHleV5EgRFxbXfGz3GA/w3hP5FP7fdEF8ZEnHm4IV7bpLanTVms+adCFrHeVj3 hakp5t4TS+l9WXjU4gBBct7tE/U55bIF0SYAZzXwXaFg38m7WcBXj5QqzUoE5+P6 m21DinoiUchek6Su/EbRXIvNkC720C65mPaj5gHL6EEfaFV1mox1t/D7TVSry2vX 0vbBGCmZyABspjMaSqAPgZSxuJ1ccBWNtxjIA+kEUhq7kB6HZrA/ThXN0rj5SmNc 2KMYL45J+LXWdvo9l243YUsnx5EKJMi+0taZYE+ZcipSbvjEZBhhouTIgDVP4wp5 fetAPCtk2XB5Crhr29CE =6T9j -----END PGP SIGNATURE----- --yVhtmJPUSI46BTXb--