From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50916) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAwGD-0002h2-ET for qemu-devel@nongnu.org; Fri, 03 Jul 2015 04:23:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZAwG8-0002Eb-JE for qemu-devel@nongnu.org; Fri, 03 Jul 2015 04:23:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41874) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAwG8-0002EX-E0 for qemu-devel@nongnu.org; Fri, 03 Jul 2015 04:23:44 -0400 Date: Fri, 3 Jul 2015 10:23:41 +0200 From: "Michael S. Tsirkin" Message-ID: <20150703102317-mutt-send-email-mst@redhat.com> References: <1433812331-18993-1-git-send-email-minyard@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433812331-18993-1-git-send-email-minyard@acm.org> Subject: Re: [Qemu-devel] [PATCH v3 00/16] Add an IPMI device to QEMU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: minyard@acm.org Cc: qemu-devel@nongnu.org On Mon, Jun 08, 2015 at 08:11:55PM -0500, minyard@acm.org wrote: > I have reworked the QEMU IPMI patches, and I believe this design > improves greatly on the previous one. The suggestions made all > resulted in better design. To start an IPMI interface > with this, you would use: > > -device ipmi-bmc-sim,id=bmc0 -device isa-ipmi-bt,bmc=bmc0 > > Note that I did not make the BMCs objects. I started this way, but > adding properties was ending up duplicating a lot of code already > in the device core, especially for the chardev link. > > I'm not sure of the importance of having a BMC be an object instead > of a device, but it seems to me that if we do that, it would be > best to add helper functions to the object core for the chardev > and integer properties. > > Thanks, > > -corey In the future pls remember to copy maintainers on patches you post.