From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46370)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ZBdbt-0002RV-4R
	for qemu-devel@nongnu.org; Sun, 05 Jul 2015 02:41:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ZBdbp-0007K1-UF
	for qemu-devel@nongnu.org; Sun, 05 Jul 2015 02:41:05 -0400
Received: from mx1.redhat.com ([209.132.183.28]:35646)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ZBdbp-0007Jl-Oh
	for qemu-devel@nongnu.org; Sun, 05 Jul 2015 02:41:01 -0400
Date: Sun, 5 Jul 2015 08:40:54 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20150705083719-mutt-send-email-mst@redhat.com>
References: <1435102773-3498-1-git-send-email-Don.Slutz@Gmail.com>
	<1435102773-3498-9-git-send-email-Don.Slutz@Gmail.com>
	<20150701082204-mutt-send-email-mst@redhat.com>
	<5596893C.7020700@Gmail.com> <5596931B.90306@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5596931B.90306@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v8 8/8] vmport: Add VMware all ring hack
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, Don Slutz <don.slutz@gmail.com>, Don Slutz <dslutz@verizon.com>, Luiz Capitulino <lcapitulino@redhat.com>, Anthony Liguori <aliguori@amazon.com>, Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>, Richard Henderson <rth@twiddle.net>

On Fri, Jul 03, 2015 at 03:50:19PM +0200, Paolo Bonzini wrote:
> 
> 
> On 03/07/2015 15:08, Don Slutz wrote:
> >>>
> >> Creating it at the pc level and propagating makes code
> >> messy but I'd go along with it if it made sense from
> >> user's point of view, but it does not seem to make sense:
> >> to me this looks more like a CPU feature than a machine property.
> >> Or the property of the vmport rpc device that you created.
> > 
> > Well this is not a clear area.  It does look more like a CPU feature.  I
> > went with a machine feature because that is where "vmport" currently is.
> 
> I think it should be a vmport property.
> 
> It would be cleaner to implement it using the MemTxAttrs mechanism, but
> for KVM I'm afraid it would be too slow (and the slowness would affect
> all I/O accesses, not just vmport ones, unless really ugly hacks are done).
> 
> Paolo

Can it ever be implemented for kvm? I couldn't think of a clean way to do it.

-- 
MST