From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39209)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1ZC3Y9-0006ph-G3
	for qemu-devel@nongnu.org; Mon, 06 Jul 2015 06:22:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1ZC3Y8-00050n-53
	for qemu-devel@nongnu.org; Mon, 06 Jul 2015 06:22:57 -0400
Received: from hall.aurel32.net ([2001:bc8:30d7:100::1]:47600)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1ZC3Y7-0004zt-VU
	for qemu-devel@nongnu.org; Mon, 06 Jul 2015 06:22:56 -0400
Date: Mon, 6 Jul 2015 12:22:51 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Message-ID: <20150706102251.GA22590@aurel32.net>
References: <20150706082535.11980.88013.stgit@PASHA-ISP>
	<20150706082543.11980.42132.stgit@PASHA-ISP>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150706082543.11980.42132.stgit@PASHA-ISP>
Subject: Re: [Qemu-devel] [PATCH v5 01/11] softmmu: add helper function to
 pass through retaddr
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
Cc: pbonzini@redhat.com, rth7680@gmail.com, leon.alrae@imgtec.com, qemu-devel@nongnu.org, agraf@suse.de

On 2015-07-06 11:25, Pavel Dovgalyuk wrote:
> This patch introduces several helpers to pass return address
> which points to the TB. Correct return address allows correct
> restoring of the guest PC and icount. These functions should be used when
> helpers embedded into TB invoke memory operations.
> 
> Reviewed-by: Richard Henderson <rth@twiddle.net>

Given that you have changed the patch, the reviewed-by should have been
removed.

> Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
> ---
>  include/exec/cpu_ldst_template.h          |   59 +++++++++++++++++++++++++----
>  include/exec/cpu_ldst_useronly_template.h |   25 ++++++++++++
>  softmmu_template.h                        |    6 ---
>  tcg/tcg.h                                 |   23 +++++++++++
>  4 files changed, 99 insertions(+), 14 deletions(-)
> 

That said it looks fine to me, so you can add mine:

Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                 http://www.aurel32.net