From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39271) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZC3YI-00071Q-Bw for qemu-devel@nongnu.org; Mon, 06 Jul 2015 06:23:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZC3YG-000592-Ak for qemu-devel@nongnu.org; Mon, 06 Jul 2015 06:23:06 -0400 Received: from hall.aurel32.net ([2001:bc8:30d7:100::1]:47613) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZC3YG-00058h-4r for qemu-devel@nongnu.org; Mon, 06 Jul 2015 06:23:04 -0400 Date: Mon, 6 Jul 2015 12:23:02 +0200 From: Aurelien Jarno Message-ID: <20150706102302.GA22681@aurel32.net> References: <20150706082535.11980.88013.stgit@PASHA-ISP> <20150706082554.11980.29092.stgit@PASHA-ISP> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150706082554.11980.29092.stgit@PASHA-ISP> Subject: Re: [Qemu-devel] [PATCH v5 03/11] target-mips: improve exceptions handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Dovgalyuk Cc: pbonzini@redhat.com, rth7680@gmail.com, leon.alrae@imgtec.com, qemu-devel@nongnu.org, agraf@suse.de On 2015-07-06 11:25, Pavel Dovgalyuk wrote: > This patch improves exception handling in MIPS. > Instructions generate several types of exceptions. > When exception is generated, it breaks the execution of the current translation > block. Implementation of the exceptions handling does not correctly > restore icount for the instruction which caused the exception. In most cases > icount will be decreased by the value equal to the size of TB. > This patch passes pointer to the translation block internals to the exception > handler. It allows correct restoring of the icount value. > > v3 changes: > This patch stops translation when instruction which always generates exception > is translated. This improves the performance of the patched version compared > to original one. > > Signed-off-by: Pavel Dovgalyuk > --- > target-mips/cpu.h | 23 +++ > target-mips/helper.h | 1 > target-mips/msa_helper.c | 158 +++++++++++--------- > target-mips/op_helper.c | 169 ++++++++++----------- > target-mips/translate.c | 363 ++++++++++++++++++++++------------------------ > 5 files changed, 359 insertions(+), 355 deletions(-) Reviewed-by: Aurelien Jarno -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://www.aurel32.net