From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57405) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZC4ON-0006hm-Gx for qemu-devel@nongnu.org; Mon, 06 Jul 2015 07:16:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZC4OI-0006Sp-JN for qemu-devel@nongnu.org; Mon, 06 Jul 2015 07:16:55 -0400 Date: Mon, 6 Jul 2015 21:09:31 +1000 From: David Gibson Message-ID: <20150706110931.GA32578@voom.redhat.com> References: <1435869974-22848-1-git-send-email-mdroth@linux.vnet.ibm.com> <20150703071841.GC16378@voom.redhat.com> <559A421B.3030707@suse.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="yrj/dFKFPuw6o+aM" Content-Disposition: inline In-Reply-To: <559A421B.3030707@suse.de> Subject: Re: [Qemu-devel] [PATCH] target-ppc: fix hugepage support when using memory-backend-file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-stable@nongnu.org, qemu-ppc@nongnu.org, Michael Roth , qemu-devel@nongnu.org --yrj/dFKFPuw6o+aM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 06, 2015 at 10:53:47AM +0200, Alexander Graf wrote: > On 07/03/15 09:18, David Gibson wrote: > >On Thu, Jul 02, 2015 at 03:46:14PM -0500, Michael Roth wrote: > >>Current PPC code relies on -mem-path being used in order for > >>hugepage support to be detected. With the introduction of > >>MemoryBackendFile we can now handle this via: > >> -object memory-file-backend,mem-path=3D...,id=3Dhugemem0 \ > >> -numa node,id=3Dmem0,memdev=3Dhugemem0 > >> > >>Management tools like libvirt treat the 2 approaches as > >>interchangeable in some cases, which can lead to user-visible > >>regressions even for previously supported guest configurations. > >> > >>Fix these by also iterating through any configured memory > >>backends that may be backed by hugepages. > >> > >>Since the old code assumed hugepages always backed the entirety > >>of guest memory, play it safe an pick the minimum across the > >>max pages sizes for all backends, even ones that aren't backed > >>by hugepages. > >> > >>Cc: qemu-stable@nongnu.org > >>Signed-off-by: Michael Roth > >Reviewed-by: David Gibson > > >=20 > Thanks, applied to ppc-next. Hrm.. I see that you've pushed out ppc-next with this patch, but looks like it hasn't been rebased on latest master. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --yrj/dFKFPuw6o+aM Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVmmHqAAoJEGw4ysog2bOSuUMP/A5B3UqfyXgYZruWm328v/eq IuOlK+Ycuo4Hvo74NBI11+KoxXuwJD9VVXEulTJhRbDergFXCWyVHb7mWxkE87dF H9TsDfzXQGbMx55aqZUgYbBN6f9SL+hZA4OoXEYskmrRd/mrTvxmx/jwTFF3xKbO 5PvC/qkNkKn+RDfQyj8v7HvAat3/OCWeXfqXQ/Klt90CMd8HGGVGDUTfEl43+wkm eq1GgwzUhlGB7JdILEfEK8CqcHK8zAgCxDDsBkEMogS3iQuSmpR/NsnpM9tElh3F HpBeY2936Sr+6nb8A1rYD4QlxpkQBJVf2239J76LT+QeIBq8QmDqSHJEgMA+pxCh llcCgh4iY+mJ8vnXMRAmQTUlewWvKn5gvJ1r6DqjIy4Y1/0Ag5XCVLJfKc/ZgYkz rMAK6yX2QsOD+XmS1XN4ah5VyzXk30ORFsTRcw6aX0eAkXWpWWsTw6jT8bhF4A8U Vpz0AjAh/ltsJCZG8QGzkpyYbW5rr1oCvkGqhmcwkyWr1pFimDjdNUDSoQkpnVbm LvkPD5KtphmCRQW5JWbjyszf97NLjYq+BnvocpQRxosvbRG682h6PdH/sUdeNUN1 rGW5yX3OfdxED7saB1JPKNkOgnMQlcWPTkoWe7bKh3lt0EwiWOdQzcizuXitrf9x iHd5rhLrewgNHmXjqe1O =zGU3 -----END PGP SIGNATURE----- --yrj/dFKFPuw6o+aM--