From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52943) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZC5Ok-0003Xf-4J for qemu-devel@nongnu.org; Mon, 06 Jul 2015 08:21:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZC5Oi-0006Qe-EO for qemu-devel@nongnu.org; Mon, 06 Jul 2015 08:21:21 -0400 Received: from hall.aurel32.net ([2001:bc8:30d7:100::1]:48257) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZC5Oi-0006Pn-8c for qemu-devel@nongnu.org; Mon, 06 Jul 2015 08:21:20 -0400 Date: Mon, 6 Jul 2015 14:21:18 +0200 From: Aurelien Jarno Message-ID: <20150706122118.GB22681@aurel32.net> References: <20150706082535.11980.88013.stgit@PASHA-ISP> <20150706082633.11980.1253.stgit@PASHA-ISP> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150706082633.11980.1253.stgit@PASHA-ISP> Subject: Re: [Qemu-devel] [PATCH v5 10/11] target-i386: remove useless PC updates List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Dovgalyuk Cc: pbonzini@redhat.com, rth7680@gmail.com, leon.alrae@imgtec.com, qemu-devel@nongnu.org, agraf@suse.de On 2015-07-06 11:26, Pavel Dovgalyuk wrote: > This patch removes useless PC updates before executing instructions. > PC can be recovered with correct exception handling by using TB return address. > > Signed-off-by: Pavel Dovgalyuk > --- > target-i386/translate.c | 25 ------------------------- > 1 files changed, 0 insertions(+), 25 deletions(-) This would be a lot easier to review, if each of this change is actually moved to the corresponding patch passing retaddr to the exception function. In addition to that you have left a few call to gen_update_cc_op(s). They are not needed if the helper doesn't read not write cc_op. Finally, this patch misses at least helper_fbld_ST0. -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://www.aurel32.net