From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39601) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZC91M-0001jI-Eh for qemu-devel@nongnu.org; Mon, 06 Jul 2015 12:13:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZC91J-0004ZY-5x for qemu-devel@nongnu.org; Mon, 06 Jul 2015 12:13:28 -0400 Date: Mon, 6 Jul 2015 18:13:13 +0200 From: Thomas Huth Message-ID: <20150706181313.7ecafd33@thh440s> In-Reply-To: <559AA7C8.9010503@ozlabs.ru> References: <1436148670-6592-1-git-send-email-aik@ozlabs.ru> <20150706175456.700503dd@thh440s> <559AA7C8.9010503@ozlabs.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH qemu v10 00/14] spapr: vfio: Enable Dynamic DMA windows (DDW) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: qemu-devel@nongnu.org, Michael Roth , Gavin Shan , Alex Williamson , qemu-ppc@nongnu.org, David Gibson On Tue, 7 Jul 2015 02:07:36 +1000 Alexey Kardashevskiy wrote: > On 07/07/2015 01:54 AM, Thomas Huth wrote: > > On Mon, 6 Jul 2015 12:10:56 +1000 > > Alexey Kardashevskiy wrote: > > ... > >> > >> This patchset adds DDW support for pseries. The host kernel changes are > >> required, available in the current upstream. > >> > >> This patchset is based on git://github.com/dgibson/qemu.git spapr-next branch. > >> > >> Please comment. Thanks! > > > > Alexey, > > > > I'm sorry, but it looks like this patch set badly fails to link when > > compiling for a non-Linux target: > > > > LINK ppc64-softmmu/qemu-system-ppc64.exe > > hw/ppc/spapr_pci.o: In function `spapr_phb_dma_capabilities_update': > > /home/thuth/devel/qemu/hw/ppc/spapr_pci.c:785: undefined reference to `spapr_phb_vfio_dma_capabilities_update' > > hw/ppc/spapr_pci.o: In function `rtas_ibm_configure_pe': > > /home/thuth/devel/qemu/hw/ppc/spapr_pci.c:601: undefined reference to `spapr_phb_vfio_eeh_configure' > > hw/ppc/spapr_pci.o: In function `rtas_ibm_set_slot_reset': > > /home/thuth/devel/qemu/hw/ppc/spapr_pci.c:573: undefined reference to `spapr_phb_vfio_eeh_reset' > > hw/ppc/spapr_pci.o: In function `rtas_ibm_read_slot_reset_state2': > > /home/thuth/devel/qemu/hw/ppc/spapr_pci.c:533: undefined reference to `spapr_phb_vfio_eeh_get_state' > > hw/ppc/spapr_pci.o: In function `rtas_ibm_set_eeh_option': > > /home/thuth/devel/qemu/hw/ppc/spapr_pci.c:455: undefined reference to `spapr_phb_vfio_eeh_set_option' > > hw/ppc/spapr_pci.o: In function `spapr_phb_hotplug_dma_sync': > > /home/thuth/devel/qemu/hw/ppc/spapr_pci.c:884: undefined reference to `spapr_phb_vfio_dma_remove_window' > > /home/thuth/devel/qemu/hw/ppc/spapr_pci.c:894: undefined reference to `spapr_phb_vfio_dma_init_window' > > hw/ppc/spapr_pci.o: In function `spapr_phb_dma_init_window': > > /home/thuth/devel/qemu/hw/ppc/spapr_pci.c:805: undefined reference to `spapr_phb_vfio_dma_init_window' > > hw/ppc/spapr_pci.o: In function `spapr_phb_dma_remove_window': > > /home/thuth/devel/qemu/hw/ppc/spapr_pci.c:834: undefined reference to `spapr_phb_vfio_dma_remove_window' > > hw/ppc/spapr_pci.o: In function `spapr_phb_reset': > > /home/thuth/devel/qemu/hw/ppc/spapr_pci.c:1538: undefined reference to `spapr_phb_vfio_eeh_reenable' > > collect2: error: ld returned 1 exit status > > > > Please make sure that this series also works if either CONFIG_LINUX > > or CONFIG_PCI are not enabled! > > > Oh. How exactly did you configure qemu to get this? I installed the mingw64 cross compiler packages (and likely some additional library packages like mingw64-zlib, -pixman, etc.), and then ran configure like this: configure' --cc=x86_64-w64-mingw32-gcc --cross-prefix=x86_64-w64-mingw32- --target-list=ppc64-softmmu Thomas