From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47031)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1ZCHoQ-0003DS-AH
	for qemu-devel@nongnu.org; Mon, 06 Jul 2015 21:36:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1ZCHoJ-00010X-0c
	for qemu-devel@nongnu.org; Mon, 06 Jul 2015 21:36:42 -0400
Received: from e35.co.us.ibm.com ([32.97.110.153]:42072)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1ZCHoI-00010E-Nw
	for qemu-devel@nongnu.org; Mon, 06 Jul 2015 21:36:34 -0400
Received: from /spool/local
	by e35.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
	Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <mdroth@linux.vnet.ibm.com>;
	Mon, 6 Jul 2015 19:36:33 -0600
Received: from b03cxnp07028.gho.boulder.ibm.com
	(b03cxnp07028.gho.boulder.ibm.com [9.17.130.15])
	by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id B556219D8026
	for <qemu-devel@nongnu.org>; Mon,  6 Jul 2015 19:27:31 -0600 (MDT)
Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170])
	by b03cxnp07028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with
	ESMTP id t671Y36235061818
	for <qemu-devel@nongnu.org>; Mon, 6 Jul 2015 18:34:03 -0700
Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1])
	by d03av04.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP
	id t671aVNl029221
	for <qemu-devel@nongnu.org>; Mon, 6 Jul 2015 19:36:31 -0600
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
From: Michael Roth <mdroth@linux.vnet.ibm.com>
References: <1432749229-4861-1-git-send-email-armbru@redhat.com>
	<87y4jki2jy.fsf@blackfin.pond.sub.org>
In-Reply-To: <87y4jki2jy.fsf@blackfin.pond.sub.org>
Message-ID: <20150707013358.17393.64638@loki>
Date: Mon, 06 Jul 2015 20:33:58 -0500
Subject: Re: [Qemu-devel] [PATCH] Revert "guest agent: remove g_strcmp0
	usage"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org

Quoting Markus Armbruster (2015-06-16 01:34:57)
> Ping?

Applied, thanks.

> =

> Markus Armbruster <armbru@redhat.com> writes:
> =

> > Since we now require GLib 2.22+ (commit f40685c), we don't have to
> > work around lack of g_strcmp0() anymore.
> >
> > This reverts commit 8f4774789947bc4bc4c8d026a289fe980d3d2ee1.
> >
> > Conflicts:
> >       qemu-ga.c
> >
> > Signed-off-by: Markus Armbruster <armbru@redhat.com>
> > ---
> >  qga/main.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/qga/main.c b/qga/main.c
> > index 9939a2b..0b788e1 100644
> > --- a/qga/main.c
> > +++ b/qga/main.c
> > @@ -274,7 +274,7 @@ static void ga_log(const gchar *domain, GLogLevelFl=
ags level,
> >  =

> >      level &=3D G_LOG_LEVEL_MASK;
> >  #ifndef _WIN32
> > -    if (domain && strcmp(domain, "syslog") =3D=3D 0) {
> > +    if (g_strcmp0(domain, "syslog") =3D=3D 0) {
> >          syslog(LOG_INFO, "%s: %s", level_str, msg);
> >      } else if (level & s->log_level) {
> >  #else
>=20