From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47052) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCHoR-0003Dd-Gt for qemu-devel@nongnu.org; Mon, 06 Jul 2015 21:36:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZCHoJ-00010w-JN for qemu-devel@nongnu.org; Mon, 06 Jul 2015 21:36:43 -0400 Received: from e17.ny.us.ibm.com ([129.33.205.207]:57672) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCHoJ-00010m-Dy for qemu-devel@nongnu.org; Mon, 06 Jul 2015 21:36:35 -0400 Received: from /spool/local by e17.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 6 Jul 2015 21:36:35 -0400 Received: from b01cxnp23034.gho.pok.ibm.com (b01cxnp23034.gho.pok.ibm.com [9.57.198.29]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id C2B126E801D for ; Mon, 6 Jul 2015 21:28:18 -0400 (EDT) Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by b01cxnp23034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t671aV5r63111180 for ; Tue, 7 Jul 2015 01:36:31 GMT Received: from d01av04.pok.ibm.com (localhost [127.0.0.1]) by d01av04.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t671aVQV007332 for ; Mon, 6 Jul 2015 21:36:31 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Roth In-Reply-To: <1436106538-32692-1-git-send-email-marcandre.lureau@redhat.com> References: <1436106538-32692-1-git-send-email-marcandre.lureau@redhat.com> Message-ID: <20150707013421.17393.30762@loki> Date: Mon, 06 Jul 2015 20:34:21 -0500 Subject: Re: [Qemu-devel] [PATCH] qga: fail early for invalid time List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , qemu-devel@nongnu.org Quoting Marc-Andr=C3=A9 Lureau (2015-07-05 09:28:58) > It's possible to set system time with dates after 2070, however, it's > not possible to set the RTC. It has limitation to up to year > 2070 (1970+100). In order to keep both clock in sync and before the > kernel complains on invalid values, bail out early. > = > Signed-off-by: Marc-Andr=C3=A9 Lureau Applied, thanks. > --- > qga/commands-posix.c | 7 +++++++ > 1 file changed, 7 insertions(+) > = > diff --git a/qga/commands-posix.c b/qga/commands-posix.c > index befd00b..d8847be 100644 > --- a/qga/commands-posix.c > +++ b/qga/commands-posix.c > @@ -154,6 +154,8 @@ void qmp_guest_set_time(bool has_time, int64_t time_n= s, Error **errp) > = > /* If user has passed a time, validate and set it. */ > if (has_time) { > + GDate date =3D { 0, }; > + > /* year-2038 will overflow in case time_t is 32bit */ > if (time_ns / 1000000000 !=3D (time_t)(time_ns / 1000000000)) { > error_setg(errp, "Time %" PRId64 " is too large", time_ns); > @@ -162,6 +164,11 @@ void qmp_guest_set_time(bool has_time, int64_t time_= ns, Error **errp) > = > tv.tv_sec =3D time_ns / 1000000000; > tv.tv_usec =3D (time_ns % 1000000000) / 1000; > + g_date_set_time_t(&date, tv.tv_sec); > + if (date.year < 1970 || date.year >=3D 2070) { > + error_setg_errno(errp, errno, "Invalid time"); > + return; > + } > = > ret =3D settimeofday(&tv, NULL); > if (ret < 0) { > -- = > 2.4.3 >=20