qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2.4] socket: pass correct size in net_socket_send()
Date: Tue, 7 Jul 2015 17:09:56 +0800	[thread overview]
Message-ID: <20150707090956.GC28682@ad.nay.redhat.com> (raw)
In-Reply-To: <1436259656-24263-1-git-send-email-jasowang@redhat.com>

On Tue, 07/07 17:00, Jason Wang wrote:
> We should pass the size of packet instead of the remaining to
> qemu_send_packet_async().
> 
> Fixes: 6e99c631f116221d169ea53953d91b8aa74d297a
>        ("net/socket: Drop net_socket_can_send")
> 
> Signed-off-by: Jason Wang <jasowang@redhat.com>

Thanks!

Reviewed-by: Fam Zheng <famz@redhat.com>

> ---
>  net/socket.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/socket.c b/net/socket.c
> index c752696..b1e3b1c 100644
> --- a/net/socket.c
> +++ b/net/socket.c
> @@ -213,7 +213,7 @@ static void net_socket_send(void *opaque)
>              if (s->index >= s->packet_len) {
>                  s->index = 0;
>                  s->state = 0;
> -                if (qemu_send_packet_async(&s->nc, s->buf, size,
> +                if (qemu_send_packet_async(&s->nc, s->buf, s->packet_len,
>                                             net_socket_send_completed) == 0) {
>                      net_socket_read_poll(s, false);
>                      break;
> -- 
> 2.1.4
> 

  reply	other threads:[~2015-07-07  9:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-07  9:00 [Qemu-devel] [PATCH 2.4] socket: pass correct size in net_socket_send() Jason Wang
2015-07-07  9:09 ` Fam Zheng [this message]
2015-07-09  9:41 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150707090956.GC28682@ad.nay.redhat.com \
    --to=famz@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).