From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53014)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1ZCOt7-0005XA-E7
	for qemu-devel@nongnu.org; Tue, 07 Jul 2015 05:10:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1ZCOt5-0007uf-DE
	for qemu-devel@nongnu.org; Tue, 07 Jul 2015 05:10:01 -0400
Received: from mx1.redhat.com ([209.132.183.28]:36314)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1ZCOt5-0007tj-6q
	for qemu-devel@nongnu.org; Tue, 07 Jul 2015 05:09:59 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (Postfix) with ESMTPS id D971D3E5B2
	for <qemu-devel@nongnu.org>; Tue,  7 Jul 2015 09:09:58 +0000 (UTC)
Date: Tue, 7 Jul 2015 17:09:56 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20150707090956.GC28682@ad.nay.redhat.com>
References: <1436259656-24263-1-git-send-email-jasowang@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1436259656-24263-1-git-send-email-jasowang@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2.4] socket: pass correct size in
	net_socket_send()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jason Wang <jasowang@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com

On Tue, 07/07 17:00, Jason Wang wrote:
> We should pass the size of packet instead of the remaining to
> qemu_send_packet_async().
> 
> Fixes: 6e99c631f116221d169ea53953d91b8aa74d297a
>        ("net/socket: Drop net_socket_can_send")
> 
> Signed-off-by: Jason Wang <jasowang@redhat.com>

Thanks!

Reviewed-by: Fam Zheng <famz@redhat.com>

> ---
>  net/socket.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/socket.c b/net/socket.c
> index c752696..b1e3b1c 100644
> --- a/net/socket.c
> +++ b/net/socket.c
> @@ -213,7 +213,7 @@ static void net_socket_send(void *opaque)
>              if (s->index >= s->packet_len) {
>                  s->index = 0;
>                  s->state = 0;
> -                if (qemu_send_packet_async(&s->nc, s->buf, size,
> +                if (qemu_send_packet_async(&s->nc, s->buf, s->packet_len,
>                                             net_socket_send_completed) == 0) {
>                      net_socket_read_poll(s, false);
>                      break;
> -- 
> 2.1.4
>