From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59250) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCPFA-00013C-O0 for qemu-devel@nongnu.org; Tue, 07 Jul 2015 05:32:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZCPF6-0001pv-Df for qemu-devel@nongnu.org; Tue, 07 Jul 2015 05:32:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36687) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCPF6-0001pb-8f for qemu-devel@nongnu.org; Tue, 07 Jul 2015 05:32:44 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id A38B992480 for ; Tue, 7 Jul 2015 09:32:43 +0000 (UTC) Date: Tue, 7 Jul 2015 10:32:41 +0100 From: Stefan Hajnoczi Message-ID: <20150707093241.GD25892@stefanha-thinkpad.redhat.com> References: <1435854281-6078-1-git-send-email-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="UfEAyuTBtIjiZzX6" Content-Disposition: inline In-Reply-To: <1435854281-6078-1-git-send-email-stefanha@redhat.com> Subject: Re: [Qemu-devel] [PATCH] block: update bdrv_drain_all()/bdrv_drain() comments List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Markus Armbruster --UfEAyuTBtIjiZzX6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 02, 2015 at 05:24:41PM +0100, Stefan Hajnoczi wrote: > The doc comments for bdrv_drain_all() and bdrv_drain() are outdated: >=20 > * The bdrv_drain() comment is a poor man's bdrv_lock()/bdrv_unlock() > which Fam Zheng is currently developing. Unfortunately this warning > was never really enough because devices keep submitting I/O and op > blockers don't prevent that. >=20 > * The bdrv_drain_all() comment is still partially correct but reflects > the nature of the implementation rather than API documentation. >=20 > Do make it clear that bdrv_drain() is only appropriate within an > AioContext. For anything spanning AioContexts you need > bdrv_drain_all(). >=20 > Cc: Markus Armbruster > Cc: Paolo Bonzini > Signed-off-by: Stefan Hajnoczi > --- > block/io.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan --UfEAyuTBtIjiZzX6 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVm5y5AAoJEJykq7OBq3PIMvkH/30QofW8LX0kYGfa/s58dH4L Ytu4LPR6OrduEwTFT/CR1mLVmYmWjgOml2Tc8bP1sQ2+flNFxxtDq2/EYcDalKRV WBFvsdLTBIKMmoiBZYKPkuKt+gWXbsgOpQNZonuHJ6pggnqfyQGQ8237CY+RnKGZ nb6AJCkL5CrGw2MJ3SgdHgmiXaNvocYAH27Dm/9vM0s6RmuzC8B2CKMmCYDuVfI7 ELEaQyuMzHJbF3lXMjQx0Y91eAJ8yKcLK681HYcbcP7TjaMDYl9vu87lpHT/ArLA +T3he2NQXKE8VX5uZQVG/01kCbMVFbfUXpMaSk0vzF6ECx9Db9e2vG8zxGt7ADA= =4Xmg -----END PGP SIGNATURE----- --UfEAyuTBtIjiZzX6--