From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55941) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCQIs-0007n6-9a for qemu-devel@nongnu.org; Tue, 07 Jul 2015 06:40:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZCQIo-00073e-Mm for qemu-devel@nongnu.org; Tue, 07 Jul 2015 06:40:42 -0400 Date: Tue, 7 Jul 2015 11:40:34 +0100 From: Stefan Hajnoczi Message-ID: <20150707104034.GC1648@stefanha-thinkpad.redhat.com> References: <1436153291-13908-1-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ZwgA9U+XZDXt4+m+" Content-Disposition: inline In-Reply-To: <1436153291-13908-1-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] blockjob: Don't sleep too short List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Kevin Wolf , qemu-block@nongnu.org, qemu-devel@nongnu.org, aderumier@odiso.com, mreitz@redhat.com, stefanha@redhat.com, pbonzini@redhat.com --ZwgA9U+XZDXt4+m+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 06, 2015 at 11:28:11AM +0800, Fam Zheng wrote: > diff --git a/include/block/blockjob.h b/include/block/blockjob.h > index 57d8ef1..3deb731 100644 > --- a/include/block/blockjob.h > +++ b/include/block/blockjob.h > @@ -146,11 +146,13 @@ void *block_job_create(const BlockJobDriver *driver= , BlockDriverState *bs, > int64_t speed, BlockCompletionFunc *cb, > void *opaque, Error **errp); > =20 > +#define BLOCK_JOB_SLEEP_NS_MIN 10000000L Please introduce a block_job_relax_cpu() or similar function instead of changing block_job_sleep_ns() to 10 millisecond minimum. This change would make legitimate <10 ms users imprecise! --ZwgA9U+XZDXt4+m+ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVm6yiAAoJEJykq7OBq3PIkcAIALjErEp9JNMsrkgdbt8ZVq6X a/TOj++ZYeSzkBNs55Sl8gVHpx4iQmRk7HgksroCmqafi6Adr7AU6UW2qYJnzSxi 86b7a4C7Uxwo8PwmqRHPSnFS50xkdg1swSnqvppK1kd4QyjZpIVsQm/X9+meuw+Y TM7a1O/EFdVwLnR6GZES0jN++hbbD07EJhikEMfxVelA45N04Dp0nX+jnJ1GwgCP dqKraNsD2h97RztIY060YkaEijRQEO8W77z3kHNrE+LQfRFeTK6rjYxX4pavXPNm GuhhWKABOVz1BY6F/cPAdBBUG+ZQUTYjFDGLN8HY19zyUV5VXKSa9XutdXjxjWY= =5oB4 -----END PGP SIGNATURE----- --ZwgA9U+XZDXt4+m+--