From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44142)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ZCOVY-0007aG-IH
	for qemu-devel@nongnu.org; Tue, 07 Jul 2015 04:45:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ZCOVS-0006pE-Dl
	for qemu-devel@nongnu.org; Tue, 07 Jul 2015 04:45:40 -0400
Received: from mx1.redhat.com ([209.132.183.28]:46447)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ZCOVS-0006o9-5S
	for qemu-devel@nongnu.org; Tue, 07 Jul 2015 04:45:34 -0400
Date: Tue, 7 Jul 2015 11:45:29 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20150707114036-mutt-send-email-mst@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] qemu build fails on xen
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: ehabkost@redhat.com, qemu-devel@nongnu.org, paul.durrant@citrix.com, pbonzini@redhat.com, "Chen, Tiejun" <tiejun.chen@intel.com>, rth@twiddle.net

The following error triggers on Fedora 22:

In file included from /scm/qemu/include/hw/xen/xen_backend.h:4:0,
                 from hw/block/xen_disk.c:39:
/scm/qemu/include/hw/xen/xen_common.h:198:18: error: conflicting types fo=
r =E2=80=98ioservid_t=E2=80=99
 typedef uint32_t ioservid_t;
                  ^
In file included from /usr/include/xen/hvm/params.h:24:0,
                 from /usr/include/xenctrl.h:46,
                 from /scm/qemu/include/hw/xen/xen_common.h:9,
                 from /scm/qemu/include/hw/xen/xen_backend.h:4,
                 from hw/block/xen_disk.c:39:
/usr/include/xen/hvm/hvm_op.h:255:18: note: previous declaration of =E2=80=
=98ioservid_t=E2=80=99 was here
 typedef uint16_t ioservid_t;
                  ^
/scm/qemu/rules.mak:57: recipe for target 'hw/block/xen_disk.o' failed
make: *** [hw/block/xen_disk.o] Error 1
make: *** Waiting for unfinished jobs....

Reverting 3996e85c1822e05c50250f8d2d1e57b6bea1229d
Author: Paul Durrant <paul.durrant@citrix.com>
Date:   Tue Jan 20 11:06:19 2015 +0000

    Xen: Use the ioreq-server API when available


Looking at that header:

#ifndef HVM_PARAM_BUFIOREQ_EVTCHN
#define HVM_PARAM_BUFIOREQ_EVTCHN 26
#endif

#define IOREQ_TYPE_PCI_CONFIG 2


typedef uint32_t ioservid_t;


Are all polluting the global namespace, not to mention, violate the codin=
g
style. Why not prefix them with Xen_, xen_ etc?


--=20
MST