Re: [Qemu-devel] [Qemu-block] [PATCH] block/raw-posix: Don't think /dev/fd/<NN> is a floppy drive.

[Stefan Hajnoczi <stefanha@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1317 bytes --]

On Wed, Jul 01, 2015 at 03:40:14PM +0100, Richard W.M. Jones wrote:
> In libguestfs we use /dev/fd/<NN> to pass pre-opened file descriptors
> to qemu-img.  Lately I've discovered that although this works, qemu
> believes that these are floppy disk images.  That in itself isn't much
> of a problem, but now qemu prints a warning about host floppy
> pass-thru being deprecated.
> 
> Extend the existing test so that it ignores /dev/fd/ as well as
> /dev/fdset/
> 
> A simple test of this, if you are using the bash shell, is:
> 
>   qemu-img info <( cat /dev/null )
> 
> without this patch:
> 
>   $ qemu-img info <( cat /dev/null )
>   qemu-img: Host floppy pass-through is deprecated
>   Support for it will be removed in a future release.
>   qemu-img: Could not open '/dev/fd/63': Could not refresh total sector count: Illegal seek
> 
> with this patch:
> 
>   $ qemu-img info <( cat /dev/null )
>   qemu-img: Could not open '/dev/fd/63': Could not refresh total sector count: Illegal seek
> 
> Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
> Fixes: https://bugs.launchpad.net/qemu/+bug/1470536
> ---
>  block/raw-posix.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]