From: Stefan Hajnoczi <stefanha@gmail.com>
To: Ting Wang <kathy.wangting@huawei.com>
Cc: kwolf@redhat.com, jcody@redhat.com, famz@redhat.com,
qemu-devel@nongnu.org, wu.wubin@huawei.com
Subject: Re: [Qemu-devel] [PATCH] blockjob: add block_job_release function
Date: Tue, 7 Jul 2015 12:53:29 +0100 [thread overview]
Message-ID: <20150707115329.GC2405@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1435311455-56048-1-git-send-email-kathy.wangting@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 584 bytes --]
On Fri, Jun 26, 2015 at 05:37:35PM +0800, Ting Wang wrote:
> There is job resource leak in function mirror_start_job,
> although bdrv_create_dirty_bitmap is unlikely failed.
> Add block_job_release for each release when needed.
>
> Signed-off-by: Ting Wang <kathy.wangting@huawei.com>
> ---
> block/mirror.c | 2 ++
> blockjob.c | 20 ++++++++++++--------
> include/block/blockjob.h | 8 ++++++++
> 3 files changed, 22 insertions(+), 8 deletions(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-07-07 11:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-26 9:37 [Qemu-devel] [PATCH] blockjob: add block_job_release function Ting Wang
2015-06-26 19:48 ` John Snow
2015-07-06 2:32 ` Ting Wang
2015-07-07 11:53 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150707115329.GC2405@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=kathy.wangting@huawei.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wu.wubin@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).