From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50938) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCRRP-0001dm-HP for qemu-devel@nongnu.org; Tue, 07 Jul 2015 07:53:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZCRRM-0006jk-S4 for qemu-devel@nongnu.org; Tue, 07 Jul 2015 07:53:35 -0400 Received: from mail-wg0-x22a.google.com ([2a00:1450:400c:c00::22a]:33837) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCRRM-0006jf-CH for qemu-devel@nongnu.org; Tue, 07 Jul 2015 07:53:32 -0400 Received: by wgfr2 with SMTP id r2so10694064wgf.1 for ; Tue, 07 Jul 2015 04:53:31 -0700 (PDT) Date: Tue, 7 Jul 2015 12:53:29 +0100 From: Stefan Hajnoczi Message-ID: <20150707115329.GC2405@stefanha-thinkpad.redhat.com> References: <1435311455-56048-1-git-send-email-kathy.wangting@huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="HG+GLK89HZ1zG0kk" Content-Disposition: inline In-Reply-To: <1435311455-56048-1-git-send-email-kathy.wangting@huawei.com> Subject: Re: [Qemu-devel] [PATCH] blockjob: add block_job_release function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ting Wang Cc: kwolf@redhat.com, jcody@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, wu.wubin@huawei.com --HG+GLK89HZ1zG0kk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 26, 2015 at 05:37:35PM +0800, Ting Wang wrote: > There is job resource leak in function mirror_start_job,=20 > although bdrv_create_dirty_bitmap is unlikely failed. > Add block_job_release for each release when needed. >=20 > Signed-off-by: Ting Wang > --- > block/mirror.c | 2 ++ > blockjob.c | 20 ++++++++++++-------- > include/block/blockjob.h | 8 ++++++++ > 3 files changed, 22 insertions(+), 8 deletions(-) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan --HG+GLK89HZ1zG0kk Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVm725AAoJEJykq7OBq3PIFKUH/ifbu16nbk27oJg+AATYSxS0 WKCOfY/JZqM2lHe8gfi+irM+GEf5sKH7uoRh4b85CDeA0XRKfNxAKLZNlCQom+sB igx/Le6opTUBb1la4Bx4vEMbKHpXhdwlqw6suNebA4sjy1aXIzyJeB1nzcYoAPDS F8eNlBC5mZsxK3FH6ZpRhB7D8f2K+084Vy/cki8Tpm2mJxvRCURgwtEBKAUSH3s8 60wm+dBCpH35BfSLP2TIB+2QgicZLhwAXxp17UTID3WC4yPJEVRed/odhmSYVQRQ Hp5eGYO7n5xWBm2FtGK7thnDx5b/T+b8rNBzIMEv/A/RQbaUjoxZ+dgW00eCgGo= =oulW -----END PGP SIGNATURE----- --HG+GLK89HZ1zG0kk--