From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45847) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCdl3-0006Lv-DH for qemu-devel@nongnu.org; Tue, 07 Jul 2015 21:02:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZCdl2-0001YV-Fl for qemu-devel@nongnu.org; Tue, 07 Jul 2015 21:02:41 -0400 Date: Wed, 8 Jul 2015 09:02:32 +0800 From: Fam Zheng Message-ID: <20150708010232.GC10382@ad.nay.redhat.com> References: <1435670385-625-1-git-send-email-famz@redhat.com> <559BE81C.90602@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <559BE81C.90602@de.ibm.com> Subject: Re: [Qemu-devel] [PATCH RFC 0/4] aio: Use epoll_wait in aio_poll List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger Cc: Kevin Wolf , pbonzini@redhat.com, Stefan Hajnoczi , qemu-devel@nongnu.org, qemu-block@nongnu.org On Tue, 07/07 16:54, Christian Borntraeger wrote: > Am 30.06.2015 um 15:19 schrieb Fam Zheng: > > epoll is more scalable than ppoll. It performs faster than ppoll when the > > number of polled fds is high. > > > > See patch 4 for an example of the senario and some benchmark data. > > > > Note: it is only effective on iothread (dataplane), while the main loop cannot > > benefit from this yet, because the iohandler and chardev GSource's don't easily > > fit into this epoll interface style (that's why main loop uses qemu_poll_ns > > directly instead of aio_poll()). > > > > There is hardly any timer activity in iothreads for now, as a result the > > timeout is always 0 or -1. Therefore, timerfd, or the said nanosecond > > epoll_pwait1 interface, which fixes the timeout granularity deficiency is not > > immediately necessary at this point, but still that will be simple to add. > > > > Please review! > > Is there a branch somewhere, so that I could give it a spin? > Here: https://github.com/famz/qemu/tree/aio-posix-epoll