From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39906) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCiZO-0005ym-FD for qemu-devel@nongnu.org; Wed, 08 Jul 2015 02:11:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZCiZL-0006aA-8B for qemu-devel@nongnu.org; Wed, 08 Jul 2015 02:10:58 -0400 Date: Wed, 8 Jul 2015 14:34:30 +1000 From: David Gibson Message-ID: <20150708043430.GM17857@voom.redhat.com> References: <1436148670-6592-1-git-send-email-aik@ozlabs.ru> <20150706175456.700503dd@thh440s> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="S66JdqtemGhvbcZP" Content-Disposition: inline In-Reply-To: <20150706175456.700503dd@thh440s> Subject: Re: [Qemu-devel] [PATCH qemu v10 00/14] spapr: vfio: Enable Dynamic DMA windows (DDW) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: Michael Roth , Alexey Kardashevskiy , qemu-devel@nongnu.org, Gavin Shan , Alex Williamson , qemu-ppc@nongnu.org --S66JdqtemGhvbcZP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 06, 2015 at 05:54:56PM +0200, Thomas Huth wrote: > On Mon, 6 Jul 2015 12:10:56 +1000 > Alexey Kardashevskiy wrote: > ... > >=20 > > This patchset adds DDW support for pseries. The host kernel changes are > > required, available in the current upstream. > >=20 > > This patchset is based on git://github.com/dgibson/qemu.git spapr-next = branch. > >=20 > > Please comment. Thanks! >=20 > Alexey, >=20 > I'm sorry, but it looks like this patch set badly fails to link when > compiling for a non-Linux target: >=20 > LINK ppc64-softmmu/qemu-system-ppc64.exe > hw/ppc/spapr_pci.o: In function `spapr_phb_dma_capabilities_update': > /home/thuth/devel/qemu/hw/ppc/spapr_pci.c:785: undefined reference to `sp= apr_phb_vfio_dma_capabilities_update' > hw/ppc/spapr_pci.o: In function `rtas_ibm_configure_pe': > /home/thuth/devel/qemu/hw/ppc/spapr_pci.c:601: undefined reference to `sp= apr_phb_vfio_eeh_configure' > hw/ppc/spapr_pci.o: In function `rtas_ibm_set_slot_reset': > /home/thuth/devel/qemu/hw/ppc/spapr_pci.c:573: undefined reference to `sp= apr_phb_vfio_eeh_reset' > hw/ppc/spapr_pci.o: In function `rtas_ibm_read_slot_reset_state2': > /home/thuth/devel/qemu/hw/ppc/spapr_pci.c:533: undefined reference to `sp= apr_phb_vfio_eeh_get_state' > hw/ppc/spapr_pci.o: In function `rtas_ibm_set_eeh_option': > /home/thuth/devel/qemu/hw/ppc/spapr_pci.c:455: undefined reference to `sp= apr_phb_vfio_eeh_set_option' > hw/ppc/spapr_pci.o: In function `spapr_phb_hotplug_dma_sync': > /home/thuth/devel/qemu/hw/ppc/spapr_pci.c:884: undefined reference to `sp= apr_phb_vfio_dma_remove_window' > /home/thuth/devel/qemu/hw/ppc/spapr_pci.c:894: undefined reference to `sp= apr_phb_vfio_dma_init_window' > hw/ppc/spapr_pci.o: In function `spapr_phb_dma_init_window': > /home/thuth/devel/qemu/hw/ppc/spapr_pci.c:805: undefined reference to `sp= apr_phb_vfio_dma_init_window' > hw/ppc/spapr_pci.o: In function `spapr_phb_dma_remove_window': > /home/thuth/devel/qemu/hw/ppc/spapr_pci.c:834: undefined reference to `sp= apr_phb_vfio_dma_remove_window' > hw/ppc/spapr_pci.o: In function `spapr_phb_reset': > /home/thuth/devel/qemu/hw/ppc/spapr_pci.c:1538: undefined reference to `s= papr_phb_vfio_eeh_reenable' > collect2: error: ld returned 1 exit status >=20 > Please make sure that this series also works if either CONFIG_LINUX > or CONFIG_PCI are not enabled! I don't think !CONFIG_PCI really needs handling - I think having CONFIG_PSERIES enabled without CONFIG_PCI is simply a configuration error - another thing to handle when and if we ever encode config dependencies in qemu. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --S66JdqtemGhvbcZP Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVnKhWAAoJEGw4ysog2bOSbvQQAOLB7lKxZOwDUE/HhkoUsipc Xb8kVsdyBv++NRg1qXU2MKnW7gNzxhGNbx6uZ0k0firWc+TIBgmtLDvb9INaKKtn 1NdhPCwhil66y2bV/4mnVVpviN3go3ashlsQieqMb9fYAUBFKdgYdcXbu9kdC66/ 2buW53Y9YrxcBBMcCbtOYcbNiDForlblVbIYe+GF83J3OZwZ3VVjexAjvgKd+nYU VaBtuxAkn95C1htsTDBvKe+Ay7P3UWdgzvzfpdN4VdAtLSXcFjVDTcyIbT671Pd/ cEgP8j1Dt9ZLOZES5zDl3D+RkKjadtfD/sn0g/gfKDSAOQ6nXoqpvX8to2hIKBNA rLFzeFSvrUr/o0vFCP1rRuEg/xt8YQmWWyNjfM4SXwL7faWsCCIPuxpMM9DdRYAL X6fB8TfSIjwZHqj1VH3D6++Sa0uO+Bey3pwEWuPz3VWVdVmrzdo82EiUTw1+XvX0 Ot2VbStZulrdTA99yB7AjvOjpvAGyWj6ESspH6QEtv0M/WF5iuBvF00tkluXXRHw p1U10aqw1dt2E68jklxiDC8es2UPw5LIZBA2ZsqqTtCI6PbNTEMMay0GorpRr+i3 VRa4b+6Gh/8IOE6l1xd93N29d9/DcKjLohg28Dmuh559urojUjfYMWYbeX04+QRs 5Qh3e1NAJuTEwkkJ/H5v =Bj3p -----END PGP SIGNATURE----- --S66JdqtemGhvbcZP--