From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51270) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCjCB-0002s0-PU for qemu-devel@nongnu.org; Wed, 08 Jul 2015 02:51:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZCjCA-0005ZW-Hm for qemu-devel@nongnu.org; Wed, 08 Jul 2015 02:51:03 -0400 Date: Wed, 8 Jul 2015 16:45:18 +1000 From: David Gibson Message-ID: <20150708064518.GO17857@voom.redhat.com> References: <1436327021-14744-1-git-send-email-david@gibson.dropbear.id.au> <559CA2B4.3090303@ozlabs.ru> <20150708053708.GN17857@voom.redhat.com> <559CC5DB.2030407@ozlabs.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="yLaBmHMi4cq+C/u4" Content-Disposition: inline In-Reply-To: <559CC5DB.2030407@ozlabs.ru> Subject: Re: [Qemu-devel] [PATCH] target-ppc: Add POWER8E_v2.1 CPU model. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: lvivier@redhat.com, thuth@redhat.com, qemu-devel@nongnu.org, agraf@suse.de, qemu-ppc@nongnu.org, abologna@redhat.com, mdroth@linuc.vnet.ibm.com, afaerber@suse.de --yLaBmHMi4cq+C/u4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 08, 2015 at 04:40:27PM +1000, Alexey Kardashevskiy wrote: > On 07/08/2015 03:37 PM, David Gibson wrote: > >On Wed, Jul 08, 2015 at 02:10:28PM +1000, Alexey Kardashevskiy wrote: > >>On 07/08/2015 01:43 PM, David Gibson wrote: > >>>From: Andrea Bolognani > >>> > >>>Add a missing PVR value for the POWER8E v2.1 CPU. Information taken > >>>from the kernel cputable. > >>> > >>>Signed-off-by: Andrea Bolognani > >>>Signed-off-by: David Gibson > >>>--- > >>> target-ppc/cpu-models.c | 4 +++- > >>> target-ppc/cpu-models.h | 1 + > >>> 2 files changed, 4 insertions(+), 1 deletion(-) > >>> > >>>Alex, > >>> > >>>Not sure if this counts as a bugfix which can be merged now we're in > >>>the hard freeze. The lack of it does mean we can't work on one of our > >>>dev machines which has this CPU. > >> > >> > >>Why is this a stopper? We stopped bothering with exact PVRs some time a= go > >>and -cpu POWER8 or -cpu host still work. > > > >Andrea, can you clarify? > > > >I think it's because libvirt likes to specify a specific CPU - and if > >it gets the new PVR from the host, qemu won't understand it. >=20 >=20 > A specific CPU in this case is "POWER8", I added this specifically for > libvirt (to allow migration between all versions of POWER8), it should not > use versioned CPUs and it does not in powerkvm. Uh.. won't that make qemu attempt to set a specific PVR, though - which will fail with recent KVM if it's not *exactly* the same as the host PVR. >=20 > There is actually a patch to make this PVR masking/subclassing nicer, I > replied to it with adding you in cc:, please have a look. Andreas Faerber > had objections which I did not really grasp then. >=20 >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --yLaBmHMi4cq+C/u4 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVnMb+AAoJEGw4ysog2bOSoKcQAMhBTOLsYpFQXWUpQK5wzPhQ QfQs0CdcheMnAmgpBSQqWlBJhBACrGRGzLXSVo8HolkOJ32ngKZJvlooiP1hOFQn Zeu1WuxXhV6KxOlEXbLbDQfxdqLDbstHwflgXKfT19DC61y222cVbiBj0CR4TPCt n4zWaTyFRMTOQapj2LRc1WyJyPJHxIZFuDSJe6joSva+TgIkJtVF4ixFMd6gZqXN Cy4U681rIg2hJdBSJf79dKaEr5Vr7U24FMQFx695OjBZVMuLP/j9Ieq7QBVI+tGT jZ1cIkh3bRKpOqq/N9D/O2o2S5C82x8gSxCu4y0cZVZex5v82mQmOw9x7MpmvSo0 IRytzNrXrJ1CpEI5dtxLG32leMUXyor3G6NJyAWJDWaaJZZSalilIEo6yX/1+xlq r5tDQIHaKrQpjRtLvpViOlNZj/eCC410NvkucfFcUHbeRXULGm4PRz+Cl1SlBSS5 09In7IuPzKmfpwX63rRfXYt775ZzffNC4jJ8AkENn4Ue4JDZO/nLzg3VqOx7CNJi xyiE0R8p6sbn81JrWKxz/6W1RzQ934wfctfiqpPIN4v2Q3MD4pDlQAV0YNglq43w x51MrW3Nv1EOwPg2sLNEH9r0bDB3nUr6CGjlE2RHoR+Ct6+znylamw4RSxxweSxi AQcvn08SuQjKm7snCVV+ =Jt2k -----END PGP SIGNATURE----- --yLaBmHMi4cq+C/u4--