From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48242) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCoKj-0000WZ-By for qemu-devel@nongnu.org; Wed, 08 Jul 2015 08:20:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZCoKf-0004g7-Rp for qemu-devel@nongnu.org; Wed, 08 Jul 2015 08:20:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51087) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCoKf-0004fk-MW for qemu-devel@nongnu.org; Wed, 08 Jul 2015 08:20:09 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 3E28F3A55ED for ; Wed, 8 Jul 2015 12:20:09 +0000 (UTC) Date: Wed, 8 Jul 2015 13:20:06 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20150708122005.GH2463@work-vm> References: <1436357310-3879-1-git-send-email-quintela@redhat.com> <1436357310-3879-3-git-send-email-quintela@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436357310-3879-3-git-send-email-quintela@redhat.com> Subject: Re: [Qemu-devel] [PATCH 2/2] migration: Trace event and migration event are different things List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: amit.shah@redhat.com, qemu-devel@nongnu.org * Juan Quintela (quintela@redhat.com) wrote: > We can want the trace event even without migration events enabled. > > Reported-by: Wen Congyang > Signed-off-by: Juan Quintela > --- > migration/migration.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/migration/migration.c b/migration/migration.c > index ede432e..ba82ff6 100644 > --- a/migration/migration.c > +++ b/migration/migration.c > @@ -216,7 +216,6 @@ static void migrate_generate_event(int new_state) > { > if (migrate_use_events()) { > qapi_event_send_migration(new_state, &error_abort); > - trace_migrate_set_state(new_state); > } > } > > @@ -528,6 +527,7 @@ void qmp_migrate_set_parameters(bool has_compress_level, > static void migrate_set_state(MigrationState *s, int old_state, int new_state) > { > if (atomic_cmpxchg(&s->state, old_state, new_state) == old_state) { > + trace_migrate_set_state(new_state); > migrate_generate_event(new_state); > } > } Reviewed-by: Dr. David Alan Gilbert > -- > 2.4.3 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK