From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55426) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCohl-0005x0-BH for qemu-devel@nongnu.org; Wed, 08 Jul 2015 08:44:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZCohk-0002ZU-Gx for qemu-devel@nongnu.org; Wed, 08 Jul 2015 08:44:01 -0400 Date: Wed, 8 Jul 2015 14:43:49 +0200 From: Kevin Wolf Message-ID: <20150708124349.GJ4117@noname.redhat.com> References: <04bf5acbb995258f57f86f6922d3053dd45dd3cd.1433521455.git.berto@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <04bf5acbb995258f57f86f6922d3053dd45dd3cd.1433521455.git.berto@igalia.com> Subject: Re: [Qemu-devel] [PATCH v6 2/4] qcow2: add option to clean unused cache entries after some time List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, Stefan Hajnoczi , Max Reitz Am 05.06.2015 um 18:27 hat Alberto Garcia geschrieben: > This adds a new 'cache-clean-interval' option that cleans all qcow2 > cache entries that haven't been used in a certain interval, given in > seconds. > > This allows setting a large L2 cache size so it can handle scenarios > with lots of I/O and at the same time use little memory during periods > of inactivity. > > This feature currently relies on MADV_DONTNEED to free that memory, so > it is not useful in systems that don't follow that behavior. > > Signed-off-by: Alberto Garcia > Reviewed-by: Max Reitz This patch doesn't apply cleanly any more. Can you please rebase and change the QAPI documenation to say "since 2.5"? Kevin