From: Stefan Hajnoczi <stefanha@gmail.com>
To: John Snow <jsnow@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] trivial: remove trailing newline from error_report
Date: Thu, 9 Jul 2015 11:26:23 +0100 [thread overview]
Message-ID: <20150709102623.GC28530@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1435611386-29316-1-git-send-email-jsnow@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 610 bytes --]
On Mon, Jun 29, 2015 at 04:56:26PM -0400, John Snow wrote:
> Minor cleanup.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> hw/ide/ahci.c | 2 +-
> hw/vfio/platform.c | 2 +-
> net/tap-linux.c | 4 ++--
> 3 files changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Laszlo Ersek suggested a compile-time check (e.g. BUILD_BUG_ON()). Have
you looked into this?
Perhaps something along the lines of:
BUILD_BUG_ON(__builtin_constant_p(fmt) &&
__builtin_strlen(fmt) > 0 &&
fmt[__builtin_strlen(fmt) - 1] == '\n')
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-07-09 10:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-29 20:56 [Qemu-devel] [PATCH v2] trivial: remove trailing newline from error_report John Snow
2015-06-30 1:09 ` Gonglei
2015-07-09 10:26 ` Stefan Hajnoczi [this message]
2015-08-25 0:19 ` John Snow
2015-09-03 14:31 ` Stefan Hajnoczi
2015-09-06 10:56 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150709102623.GC28530@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=jsnow@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).