From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56230)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1ZDCL9-0004mt-O6
	for qemu-devel@nongnu.org; Thu, 09 Jul 2015 09:58:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1ZDCL8-0004MT-JB
	for qemu-devel@nongnu.org; Thu, 09 Jul 2015 09:58:15 -0400
Received: from hall.aurel32.net ([2001:bc8:30d7:100::1]:39538)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1ZDCL8-0004L4-DB
	for qemu-devel@nongnu.org; Thu, 09 Jul 2015 09:58:14 -0400
Date: Thu, 9 Jul 2015 15:58:03 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Message-ID: <20150709135803.GA20210@aurel32.net>
References: <1436433435-24898-1-git-send-email-james.hogan@imgtec.com>
	<1436433435-24898-2-git-send-email-james.hogan@imgtec.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <1436433435-24898-2-git-send-email-james.hogan@imgtec.com>
Subject: Re: [Qemu-devel] [PATCH for 2.4 1/2] tcg/mips: Fix build error from
 merged memop+mmu_idx parameter
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: James Hogan <james.hogan@imgtec.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Leon Alrae <leon.alrae@imgtec.com>, qemu-devel@nongnu.org, Richard Henderson <rth@twiddle.net>

On 2015-07-09 10:17, James Hogan wrote:
> Commit 3972ef6f830d ("tcg: Push merged memop+mmu_idx parameter to
> softmmu routines") caused the following build errors when building TCG
> for MIPS:
>=20
> In file included from tcg/tcg.c:258:0:
> tcg/mips/tcg-target.c In function =E2=80=98tcg_out_qemu_ld_slow_path=E2=
=80=99:
> tcg/mips/tcg-target.c:1015:22: error: =E2=80=98lb=E2=80=99 undeclared (fi=
rst use in this function)
> tcg/mips/tcg-target.c In function =E2=80=98tcg_out_qemu_st_slow_path=E2=
=80=99:
> tcg/mips/tcg-target.c:1058:22: error: =E2=80=98lb=E2=80=99 undeclared (fi=
rst use in this function)
>=20
> It looks like lb was meant to refer to the TCGLabelQemuLdst *l
> parameter, so fix both references to lb to refer to just l.
>=20
> Fixes: 3972ef6f830d ("tcg: Push merged memop+mmu_idx parameter to softmmu=
 routines")
> Signed-off-by: James Hogan <james.hogan@imgtec.com>
> Cc: Aurelien Jarno <aurelien@aurel32.net>
> Cc: Leon Alrae <leon.alrae@imgtec.com>
> Cc: Richard Henderson <rth@twiddle.net>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> ---
>  tcg/mips/tcg-target.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Acked-by: Aurelien Jarno <aurelien@aurel32.net>

I was planning to test various hosts after the rc0 release, but it seems
you have been faster. Unfortunately we have more regressions, I am going
to send some more mails.

I am fine if it can be merged directly.

--=20
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                 http://www.aurel32.net