From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46991) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZDBtT-0005Iu-MW for qemu-devel@nongnu.org; Thu, 09 Jul 2015 09:29:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZDBtO-0004e0-P7 for qemu-devel@nongnu.org; Thu, 09 Jul 2015 09:29:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41602) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZDBtO-0004dr-5r for qemu-devel@nongnu.org; Thu, 09 Jul 2015 09:29:34 -0400 Date: Thu, 9 Jul 2015 16:29:30 +0300 From: "Michael S. Tsirkin" Message-ID: <20150709162723-mutt-send-email-mst@redhat.com> References: <20150702012121.GA4477@ad.nay.redhat.com> <20150708173423-mutt-send-email-mst@redhat.com> <20150709132248.GA12399@stefanha-thinkpad.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150709132248.GA12399@stefanha-thinkpad.redhat.com> Subject: Re: [Qemu-devel] virtio-blk multiqueue support in qemu. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Naredula Janardhana Reddy , Fam Zheng , Ming Lei , Stefan Hajnoczi , qemu-devel@nongnu.org On Thu, Jul 09, 2015 at 02:22:48PM +0100, Stefan Hajnoczi wrote: > On Wed, Jul 08, 2015 at 05:37:12PM +0300, Michael S. Tsirkin wrote: > > On Thu, Jul 02, 2015 at 09:21:21AM +0800, Fam Zheng wrote: > > > On Wed, 07/01 22:45, Naredula Janardhana Reddy wrote: > > > > HI, > > > > I am trying to improve the throughput of virtio-blk for my kernel ( > > > > https://github.com/naredula-jana/Jiny-Kernel ) to make use of the > > > > multi-core using multi-queue. But I found the latest qemu does not support > > > > multiqueue for virtio-blk, The feature flag does not return multi-queue > > > > support. Do we have any patches to the qemu for enabling multi-queue for > > > > virtio-blk similar to that of virtio-net. Can someone help some pointers > > > > related to this.. > > > > > > There was a series last year adding support for multi-queue but wan't merged to > > > the code base: > > > > > > http://comments.gmane.org/gmane.comp.emulators.qemu/289126 > > > > > > Fam > > > > Looks like it was mostly about the missing GPL license on some files. > > Or did I miss some bigger issues? > > I reviewed the series again. The most important part: > > It was not a true multiqueue implementation - all the virtqueues are > handled from a single thread in QEMU. The reason for this is that > QEMU's block layer isn't threadsafe so a lot of work is necessary to > support true multiqueue. > > Also, the performance numbers quoted cannot be attributed to multiqueue > due to the number of additional changes the series made. In the > meantime, some of these additional changes have been merged as separate > series. > > On the positive side, we do need something similar to the last 3 patches > to expose multiqueue to the guest. But it will require much more work > in QEMU to achieve true multiqueue. > > Stefan Might this be useful as an intermediate step, e.g. for testing guest code? -- MST