From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50721) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZDrSj-00060E-5A for qemu-devel@nongnu.org; Sat, 11 Jul 2015 05:52:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZDrSf-00078c-58 for qemu-devel@nongnu.org; Sat, 11 Jul 2015 05:52:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46790) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZDrSe-00078Y-W4 for qemu-devel@nongnu.org; Sat, 11 Jul 2015 05:52:45 -0400 Date: Sat, 11 Jul 2015 11:52:40 +0200 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Message-ID: <20150711095239.GA12149@potion.redhat.com> References: <1436548682-9315-1-git-send-email-rkrcmar@redhat.com> <1436548682-9315-3-git-send-email-rkrcmar@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1436548682-9315-3-git-send-email-rkrcmar@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 2/3] crypto: avoid undefined behavior in nettle calls List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell 2015-07-10 19:18+0200, Radim Kr=C4=8Dm=C3=A1=C5=99: > diff --git a/crypto/cipher-nettle.c b/crypto/cipher-nettle.c > +void aes_encrypt_wrapper(cipher_ctx_t ctx, cipher_length_t length, > + uint8_t *dst, const uint8_t *src) Wrappers should be static (rushed posting). I'll send v3 on Wed/Thu. > +{ > + aes_encrypt(ctx, length, dst, src); > +}