From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49213)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1ZEdX3-0002Ms-EP
	for qemu-devel@nongnu.org; Mon, 13 Jul 2015 09:12:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1ZEdWw-0003Wx-3r
	for qemu-devel@nongnu.org; Mon, 13 Jul 2015 09:12:29 -0400
Received: from mail-pa0-x230.google.com ([2607:f8b0:400e:c03::230]:32867)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1ZEdWv-0003Wl-TC
	for qemu-devel@nongnu.org; Mon, 13 Jul 2015 09:12:22 -0400
Received: by padck2 with SMTP id ck2so42766925pad.0
	for <qemu-devel@nongnu.org>; Mon, 13 Jul 2015 06:12:21 -0700 (PDT)
Date: Mon, 13 Jul 2015 23:12:16 +1000
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Message-ID: <20150713131215.GA4658@toto>
References: <1434419515-3572-1-git-send-email-edgar.iglesias@gmail.com>
	<1434419515-3572-5-git-send-email-edgar.iglesias@gmail.com>
	<CAFEAcA_BbqAmmoNHfY4YNGkq2neKWP8tPx-d6Y6Cp6T9SXtj-Q@mail.gmail.com>
	<CAJy5ezpkhKqEa=XxK7-Bqc8oQmBTu=c=DhqfWKrDHb2Nj==k_w@mail.gmail.com>
	<CAFEAcA8FjAFQOvr4ZhgzVY0QFsSb-4WdLgoE-LXkN6++KiLm7g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA8FjAFQOvr4ZhgzVY0QFsSb-4WdLgoE-LXkN6++KiLm7g@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH v5 4/6] target-arm: Add the Hypervisor timer
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Sergey Fedorov <serge.fdrv@gmail.com>, Alex =?iso-8859-1?Q?Benn=E9e?= <alex.bennee@linaro.org>, Alexander Graf <agraf@suse.de>, QEMU Developers <qemu-devel@nongnu.org>

On Fri, Jul 10, 2015 at 12:25:56PM +0100, Peter Maydell wrote:
> On 10 July 2015 at 12:23, Edgar E. Iglesias <edgar.iglesias@gmail.com> wrote:
> >
> > On 10/07/2015 7:58 pm, "Peter Maydell" <peter.maydell@linaro.org> wrote:
> >> Something I just noticed while I was trying to add support
> >> for the secure physical timer on top of this series: the
> >> gt_*_cnt_reset functions are misnamed, because they're not
> >> resetting the counters, they're resetting the timers.
> >> (There are only two counters, physical and virtual, but there
> >> are four timers, physical, secure-physical, virtual and hyp.
> >> Since our reset function is deleting the underlying QEMU
> >> timer it's a timer reset, not a counter reset.)
> >> We should probably fix up the names and make sure they're
> >> associated with the correct registers (the phys and virt
> >> timer reset is currently hanging off a counter register)
> 
> > Hi, yes that sounds good. Btw are you fixing this as you go or should I send
> > a new series fixing your comments? I've fixed the stuff you commented on a
> > few days ago in my tree...
> 
> I rebased as I was reviewing it and am currently basing my
> secure-timer patches on that. It would probably be good if
> you fixed up the naming issue here and resent, and then I'll
> rebase on top of that.
>

Hi Peter,

I've just sent out a v6 hopefully addressing your comments.

I noticed that the naming is a bit incosistent with the timers but didn't
want to change too much in case you've got patches on top.

The timer and counter functions can be renamed to consistenly use

_phys_
_sec_phys_
_virt_
_hyp_ 

Or:
_p
_sp
_v
_h

Or any other reasonable combo.

We can patch into my series or do as followup

Cheers,
Edgar