From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52040)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ZEbpL-0007RO-0W
	for qemu-devel@nongnu.org; Mon, 13 Jul 2015 07:23:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ZEbpG-0005H2-1S
	for qemu-devel@nongnu.org; Mon, 13 Jul 2015 07:23:14 -0400
Received: from mx1.redhat.com ([209.132.183.28]:40897)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ZEbpF-0005Gw-Sy
	for qemu-devel@nongnu.org; Mon, 13 Jul 2015 07:23:09 -0400
Date: Mon, 13 Jul 2015 14:23:06 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20150713142240-mutt-send-email-mst@redhat.com>
References: <1436439674-51226-1-git-send-email-cornelia.huck@de.ibm.com>
	<20150713110144.6b6befae.cornelia.huck@de.ibm.com>
	<55A39077.1060208@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <55A39077.1060208@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-2.4] qdev: fix 64 bit properties
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>, qemu-devel@nongnu.org, kraxel@redhat.com

On Mon, Jul 13, 2015 at 12:18:31PM +0200, Paolo Bonzini wrote:
> 
> 
> On 13/07/2015 11:01, Cornelia Huck wrote:
> > On Thu,  9 Jul 2015 13:01:14 +0200
> > Cornelia Huck <cornelia.huck@de.ibm.com> wrote:
> > 
> >> 64 bit props used 32 bit callbacks in two places, leading to broken
> >> feature bits on virtio (example: got 0x31000000000006d4 which is
> >> obviously bogus). Fix this.
> >>
> >> Fixes: fdba6d96 ("qdev: add 64bit properties")
> >> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> >> ---
> >>  hw/core/qdev-properties.c    | 2 +-
> >>  include/hw/qdev-properties.h | 2 +-
> >>  2 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > Ping? I think this should go into 2.4-rc1.
> 
> I'll queue it.
> 
> Paolo

No need, I already have it queued. Want to send an ack?

-- 
MST