From: "Michael S. Tsirkin" <mst@redhat.com>
To: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] pci_add_capability: remove duplicate comments
Date: Mon, 13 Jul 2015 14:47:29 +0300 [thread overview]
Message-ID: <20150713144641-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <1436773597-3762-1-git-send-email-chenhanxiao@cn.fujitsu.com>
On Mon, Jul 13, 2015 at 03:46:37PM +0800, Chen Hanxiao wrote:
> Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
> ---
> hw/pci/pci.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/hw/pci/pci.c b/hw/pci/pci.c
> index 442f822..dfd2abc 100644
> --- a/hw/pci/pci.c
> +++ b/hw/pci/pci.c
> @@ -2101,12 +2101,10 @@ static void pci_del_option_rom(PCIDevice *pdev)
> }
>
> /*
> - * if !offset
> - * Reserve space and add capability to the linked list in pci config space
> - *
> * if offset = 0,
> * Find and reserve space and add capability to the linked list
> - * in pci config space */
> + * in pci config space
> + * /
> int pci_add_capability(PCIDevice *pdev, uint8_t cap_id,
> uint8_t offset, uint8_t size)
> {
This doesn't compile.
> --
> 2.1.0
prev parent reply other threads:[~2015-07-13 11:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 7:46 [Qemu-devel] [PATCH] pci_add_capability: remove duplicate comments Chen Hanxiao
2015-07-13 11:47 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150713144641-mutt-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=chenhanxiao@cn.fujitsu.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).