* [Qemu-devel] [PATCH] pci_add_capability: remove duplicate comments
@ 2015-07-13 7:46 Chen Hanxiao
2015-07-13 11:47 ` Michael S. Tsirkin
0 siblings, 1 reply; 2+ messages in thread
From: Chen Hanxiao @ 2015-07-13 7:46 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
---
hw/pci/pci.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index 442f822..dfd2abc 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -2101,12 +2101,10 @@ static void pci_del_option_rom(PCIDevice *pdev)
}
/*
- * if !offset
- * Reserve space and add capability to the linked list in pci config space
- *
* if offset = 0,
* Find and reserve space and add capability to the linked list
- * in pci config space */
+ * in pci config space
+ * /
int pci_add_capability(PCIDevice *pdev, uint8_t cap_id,
uint8_t offset, uint8_t size)
{
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] pci_add_capability: remove duplicate comments
2015-07-13 7:46 [Qemu-devel] [PATCH] pci_add_capability: remove duplicate comments Chen Hanxiao
@ 2015-07-13 11:47 ` Michael S. Tsirkin
0 siblings, 0 replies; 2+ messages in thread
From: Michael S. Tsirkin @ 2015-07-13 11:47 UTC (permalink / raw)
To: Chen Hanxiao; +Cc: qemu-devel
On Mon, Jul 13, 2015 at 03:46:37PM +0800, Chen Hanxiao wrote:
> Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
> ---
> hw/pci/pci.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/hw/pci/pci.c b/hw/pci/pci.c
> index 442f822..dfd2abc 100644
> --- a/hw/pci/pci.c
> +++ b/hw/pci/pci.c
> @@ -2101,12 +2101,10 @@ static void pci_del_option_rom(PCIDevice *pdev)
> }
>
> /*
> - * if !offset
> - * Reserve space and add capability to the linked list in pci config space
> - *
> * if offset = 0,
> * Find and reserve space and add capability to the linked list
> - * in pci config space */
> + * in pci config space
> + * /
> int pci_add_capability(PCIDevice *pdev, uint8_t cap_id,
> uint8_t offset, uint8_t size)
> {
This doesn't compile.
> --
> 2.1.0
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-13 11:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-13 7:46 [Qemu-devel] [PATCH] pci_add_capability: remove duplicate comments Chen Hanxiao
2015-07-13 11:47 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).