From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57804) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZEcCu-00079m-G4 for qemu-devel@nongnu.org; Mon, 13 Jul 2015 07:47:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZEcCq-0007UA-Fj for qemu-devel@nongnu.org; Mon, 13 Jul 2015 07:47:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33669) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZEcCq-0007U6-AQ for qemu-devel@nongnu.org; Mon, 13 Jul 2015 07:47:32 -0400 Date: Mon, 13 Jul 2015 14:47:29 +0300 From: "Michael S. Tsirkin" Message-ID: <20150713144641-mutt-send-email-mst@redhat.com> References: <1436773597-3762-1-git-send-email-chenhanxiao@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436773597-3762-1-git-send-email-chenhanxiao@cn.fujitsu.com> Subject: Re: [Qemu-devel] [PATCH] pci_add_capability: remove duplicate comments List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chen Hanxiao Cc: qemu-devel@nongnu.org On Mon, Jul 13, 2015 at 03:46:37PM +0800, Chen Hanxiao wrote: > Signed-off-by: Chen Hanxiao > --- > hw/pci/pci.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/hw/pci/pci.c b/hw/pci/pci.c > index 442f822..dfd2abc 100644 > --- a/hw/pci/pci.c > +++ b/hw/pci/pci.c > @@ -2101,12 +2101,10 @@ static void pci_del_option_rom(PCIDevice *pdev) > } > > /* > - * if !offset > - * Reserve space and add capability to the linked list in pci config space > - * > * if offset = 0, > * Find and reserve space and add capability to the linked list > - * in pci config space */ > + * in pci config space > + * / > int pci_add_capability(PCIDevice *pdev, uint8_t cap_id, > uint8_t offset, uint8_t size) > { This doesn't compile. > -- > 2.1.0