From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36489) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZEh6q-0000gP-Sg for qemu-devel@nongnu.org; Mon, 13 Jul 2015 13:01:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZEh6m-0001kJ-O5 for qemu-devel@nongnu.org; Mon, 13 Jul 2015 13:01:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33742) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZEh6m-0001kB-Gc for qemu-devel@nongnu.org; Mon, 13 Jul 2015 13:01:36 -0400 Date: Mon, 13 Jul 2015 20:01:31 +0300 From: "Michael S. Tsirkin" Message-ID: <20150713200122-mutt-send-email-mst@redhat.com> References: <1436247191-13577-1-git-send-email-tiejun.chen@intel.com> <1436247191-13577-9-git-send-email-tiejun.chen@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [v9][PATCH 08/10] xen, gfx passthrough: register a isa bridge List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefano Stabellini Cc: qemu-devel@nongnu.org, Tiejun Chen , rth@twiddle.net, ehabkost@redhat.com, pbonzini@redhat.com On Mon, Jul 13, 2015 at 05:14:08PM +0100, Stefano Stabellini wrote: > On Tue, 7 Jul 2015, Tiejun Chen wrote: > > Currently we just register this isa bridge when we use IGD > > passthrough in Xen side. > > > > Signed-off-by: Tiejun Chen > > Acked-by: Stefano Stabellini > > --- > > v9: > > > > * Move is_igd_vga_passthrough(dev)) from xen_igd_passthrough_isa_bridge_create() > > into xen_pt_initfn(). > > > > hw/xen/xen_pt.c | 21 +++++++++++++++++++++ > > include/hw/xen/xen.h | 1 + > > 2 files changed, 22 insertions(+) > > > > diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c > > index 15b02cb..f764131 100644 > > --- a/hw/xen/xen_pt.c > > +++ b/hw/xen/xen_pt.c > > @@ -684,6 +684,17 @@ static const MemoryListener xen_pt_io_listener = { > > .priority = 10, > > }; > > > > +static void > > +xen_igd_passthrough_isa_bridge_create(XenPCIPassthroughState *s, > > + XenHostPCIDevice *dev) > > +{ > > + uint16_t gpu_dev_id; > > + PCIDevice *d = &s->dev; > > + > > + gpu_dev_id = dev->device_id; > > + igd_passthrough_isa_bridge_create(d->bus, gpu_dev_id); > > +} > > + > > /* init */ > > > > static int xen_pt_initfn(PCIDevice *d) > > @@ -728,11 +739,21 @@ static int xen_pt_initfn(PCIDevice *d) > > /* Setup VGA bios for passthrough GFX */ > > if ((s->real_device.domain == 0) && (s->real_device.bus == 0) && > > (s->real_device.dev == 2) && (s->real_device.func == 0)) { > > + if (!is_igd_vga_passthrough(&s->real_device)) { > > + XEN_PT_ERR(d, "Need to enable igd-passthru if you're trying" > > + " to passthrough IGD GFX.\n"); > > + xen_host_pci_device_put(&s->real_device); > > + return -1; > > + } > > This is OK now, thanks. > > > > if (xen_pt_setup_vga(s, &s->real_device) < 0) { > > XEN_PT_ERR(d, "Setup VGA BIOS of passthrough GFX failed!\n"); > > xen_host_pci_device_put(&s->real_device); > > return -1; > > } > > + > > + /* Register ISA bridge for passthrough GFX. */ > > + xen_igd_passthrough_isa_bridge_create(s, &s->real_device); > > } > > > > /* Handle real device's MMIO/PIO BARs */ > > diff --git a/include/hw/xen/xen.h b/include/hw/xen/xen.h > > index 4356af4..703148e 100644 > > --- a/include/hw/xen/xen.h > > +++ b/include/hw/xen/xen.h > > @@ -51,4 +51,5 @@ void xen_register_framebuffer(struct MemoryRegion *mr); > > # define HVM_MAX_VCPUS 32 > > #endif > > > > +extern void igd_passthrough_isa_bridge_create(PCIBus *bus, uint16_t gpu_dev_id); > > #endif /* QEMU_HW_XEN_H */ > > You are right that I was confused on my previous comment, but it is true > that it shouldn't be part of this patch: it should be part of patch > 7/10. Also the declaration should probably not be in the xen.h header. > > Michael, where do you think should go? Donnu - add a header?