From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51045) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZEk1L-0006MU-Tp for qemu-devel@nongnu.org; Mon, 13 Jul 2015 16:08:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZEk1I-0003sd-Nj for qemu-devel@nongnu.org; Mon, 13 Jul 2015 16:08:11 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:57054) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZEk1I-0003s5-IY for qemu-devel@nongnu.org; Mon, 13 Jul 2015 16:08:08 -0400 Date: Mon, 13 Jul 2015 13:08:02 -0700 From: Meador Inge Message-ID: <20150713200801.GA24071@mentor.com> References: <1436205821-20320-1-git-send-email-meadori@codesourcery.com> <1436205821-20320-2-git-send-email-meadori@codesourcery.com> <559ADA58.9020409@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <559ADA58.9020409@vivier.eu> Subject: Re: [Qemu-devel] [PATCH 1/4] linux-user: Exit 0 when -h is used List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier Cc: riku.voipio@iki.fi, qemu-devel@nongnu.org On Mon, Jul 06, 2015 at 09:43:20PM +0200, Laurent Vivier wrote: > Global comment: you should use EXIT_SUCCESS and EXIT_FAILURE from stdlib.h On second thought, I was following an existing pattern in 'main.c'. Really fixing this would require changing around 30 other locations too. I think if we are going to switch to the EXIT_* macros, then the whole file should be changed in one patch and making that fix shouldn't hold this patch up. -- Meador