From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58067)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1ZEr14-0007mp-Er
	for qemu-devel@nongnu.org; Mon, 13 Jul 2015 23:36:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1ZEr10-0002a6-3t
	for qemu-devel@nongnu.org; Mon, 13 Jul 2015 23:36:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:33654)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1ZEr0z-0002Zy-Vv
	for qemu-devel@nongnu.org; Mon, 13 Jul 2015 23:36:18 -0400
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
	(int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
	by mx1.redhat.com (Postfix) with ESMTPS id DF901373F29
	for <qemu-devel@nongnu.org>; Tue, 14 Jul 2015 03:36:16 +0000 (UTC)
Date: Tue, 14 Jul 2015 11:36:14 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20150714033614.GD24907@ad.nay.redhat.com>
References: <1436787065-25095-1-git-send-email-pbonzini@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1436787065-25095-1-git-send-email-pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/3] rcu: missing thread registration
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

On Mon, 07/13 13:31, Paolo Bonzini wrote:
> Patch 2 fixes the problem, whereby threads were not being registered
> but still happily used RCU.  Patch 1 simplifies the registration by
> making rcu_unregister_thread automatic.  Patch 3 avoids having the
> same bug in the future.

Reviewed-by: Fam Zheng <famz@redhat.com>

> 
> Paolo
> 
> Paolo Bonzini (3):
>   rcu: automatically unregister threads when they exit
>   rcu: actually register threads that have RCU read-side critical
>     sections
>   rcu: detect missing rcu_register_thread()
> 
>  cpus.c                |  6 ++++++
>  include/qemu/rcu.h    |  4 +++-
>  iothread.c            |  3 +++
>  migration/migration.c |  3 +++
>  tests/rcutorture.c    | 10 ----------
>  tests/test-rcu-list.c |  2 ++
>  util/rcu.c            | 30 ++++++++++++++++++++++++++++--
>  7 files changed, 45 insertions(+), 13 deletions(-)
> 
> -- 
> 2.4.3
> 
>