From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: peter.crosthwaite@xilinx.com, qemu-devel@nongnu.org,
agraf@suse.de, Christian Borntraeger <borntraeger@de.ibm.com>,
jfrei@linux.vnet.ibm.com, gesaint@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH for-2.4 1/2] core: reset handler for bus-less devices
Date: Tue, 14 Jul 2015 09:41:18 +0200 [thread overview]
Message-ID: <20150714094118.46a2338b.cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <55A3E215.20305@suse.de>
On Mon, 13 Jul 2015 18:06:45 +0200
Andreas Färber <afaerber@suse.de> wrote:
> Found it. So the problem *is* different from what I understood! It's not
> directly attached to /machine by s390x code, but rather instantiated via
> -device by the user.
>
> Peter C. suggested you to do it in realize, which affects all devices.
>
> The solution would be to instead either do the reset registration in
> qdev-monitor.c, where it's specific to devices that do not have a bus
> and on /machine/peripheral or /machine/periph-anon are not managed by a
> parent, or to add a further check here in realized. Right now I can only
> think of a hot-plug flag...? Not sure about unrealizing in the
> qdev-monitor case, but I think we can ignore that in this case?
This sounds not like something we'll want to do during hardfreeze,
though.
I'll just fall back to the original patch that registered a reset so
this works for now, and we can think of a more generic solution later.
next prev parent reply other threads:[~2015-07-14 7:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 16:51 [Qemu-devel] [PATCH for-2.4 0/2] reset for bus-less devices Cornelia Huck
2015-07-09 16:51 ` [Qemu-devel] [PATCH for-2.4 1/2] core: reset handler " Cornelia Huck
2015-07-09 16:59 ` Andreas Färber
2015-07-09 18:53 ` Peter Crosthwaite
2015-07-13 14:28 ` Paolo Bonzini
2015-07-13 12:22 ` Christian Borntraeger
2015-07-13 14:11 ` Cornelia Huck
2015-07-13 14:20 ` Andreas Färber
2015-07-13 14:30 ` Christian Borntraeger
2015-07-13 15:05 ` Andreas Färber
2015-07-13 15:38 ` Cornelia Huck
2015-07-13 15:49 ` Andreas Färber
2015-07-13 15:56 ` Peter Maydell
2015-07-13 14:37 ` Cornelia Huck
2015-07-13 16:06 ` Andreas Färber
2015-07-14 7:41 ` Cornelia Huck [this message]
2015-07-09 16:51 ` [Qemu-devel] [PATCH for-2.4 2/2] watchdog/diag288: handle subsystem resets correctly Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150714094118.46a2338b.cornelia.huck@de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=gesaint@linux.vnet.ibm.com \
--cc=jfrei@linux.vnet.ibm.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).