From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35199)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1ZEuqI-0005cF-PX
	for qemu-devel@nongnu.org; Tue, 14 Jul 2015 03:41:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1ZEuqF-00045b-IS
	for qemu-devel@nongnu.org; Tue, 14 Jul 2015 03:41:30 -0400
Received: from e06smtp13.uk.ibm.com ([195.75.94.109]:53924)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1ZEuqF-00044a-8b
	for qemu-devel@nongnu.org; Tue, 14 Jul 2015 03:41:27 -0400
Received: from /spool/local
	by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <cornelia.huck@de.ibm.com>;
	Tue, 14 Jul 2015 08:41:24 +0100
Received: from b06cxnps3075.portsmouth.uk.ibm.com
	(d06relay10.portsmouth.uk.ibm.com [9.149.109.195])
	by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id D359217D805A
	for <qemu-devel@nongnu.org>; Tue, 14 Jul 2015 08:42:39 +0100 (BST)
Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com
	[9.149.37.217])
	by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with
	ESMTP id t6E7fKuV34537704
	for <qemu-devel@nongnu.org>; Tue, 14 Jul 2015 07:41:21 GMT
Received: from d06av06.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av06.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id t6E2Y94g014041
	for <qemu-devel@nongnu.org>; Mon, 13 Jul 2015 22:34:10 -0400
Date: Tue, 14 Jul 2015 09:41:18 +0200
From: Cornelia Huck <cornelia.huck@de.ibm.com>
Message-ID: <20150714094118.46a2338b.cornelia.huck@de.ibm.com>
In-Reply-To: <55A3E215.20305@suse.de>
References: <1436460692-5142-1-git-send-email-cornelia.huck@de.ibm.com>
	<1436460692-5142-2-git-send-email-cornelia.huck@de.ibm.com>
	<55A3AD6D.5010303@de.ibm.com>
	<20150713161152.3e519fcd.cornelia.huck@de.ibm.com>
	<55A3C919.1040400@suse.de>
	<20150713163727.4b18f409.cornelia.huck@de.ibm.com>
	<55A3E215.20305@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH for-2.4 1/2] core: reset handler for
	bus-less devices
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?UTF-8?B?RsOkcmJlcg==?= <afaerber@suse.de>
Cc: peter.crosthwaite@xilinx.com, qemu-devel@nongnu.org, agraf@suse.de, Christian Borntraeger <borntraeger@de.ibm.com>, jfrei@linux.vnet.ibm.com, gesaint@linux.vnet.ibm.com

On Mon, 13 Jul 2015 18:06:45 +0200
Andreas F=C3=A4rber <afaerber@suse.de> wrote:

> Found it. So the problem *is* different from what I understood! It's not
> directly attached to /machine by s390x code, but rather instantiated via
> -device by the user.
>=20
> Peter C. suggested you to do it in realize, which affects all devices.
>=20
> The solution would be to instead either do the reset registration in
> qdev-monitor.c, where it's specific to devices that do not have a bus
> and on /machine/peripheral or /machine/periph-anon are not managed by a
> parent, or to add a further check here in realized. Right now I can only
> think of a hot-plug flag...? Not sure about unrealizing in the
> qdev-monitor case, but I think we can ignore that in this case?

This sounds not like something we'll want to do during hardfreeze,
though.

I'll just fall back to the original patch that registered a reset so
this works for now, and we can think of a more generic solution later.